On 22 January 2013 14:46, CeDeROM <[email protected]> wrote: > On Thu, Jan 17, 2013 at 10:50 PM, Spencer Oliver <[email protected]> wrote: >> On 16/01/13 22:21, Freddie Chopin wrote: >>> W dniu 2013-01-16 22:57, Spencer Oliver pisze: >>>> I have already started the rebase - >>>> http://repo.or.cz/w/openocd/ntfreak.git/shortlog/refs/heads/libswd >>>> >>>> The next step is to squash some of the commits as noted in my comments >>>> on gerrit, if you have time then feel free to continue. >>> >>> Well, in that case I think it's best for me to wait until you're done >>> with your rebase and then I can do the squashing/merging stuff, right? >>> >> >> I have rebased and squashed/cleaned a few commits. No functional changes >> yet. > > Spen, regarding the changes introduced in http://openocd.zylin.com/#/c/1077/ : > > 1. I dont agree to rename oocd_transport_allow() to allow_transports() > and similar. I have named them to that convention on purpose. Please > take a look at 'internals reorganization' thread and continue > discussion over there if you like. >
I have not renamed anything, your original patch changed the name. What my cleanup is trying todo is split the actual changes from noise. If you feel this name needs changing then that should be a separate change, otherwise it is hard for us to review. I do not see any value in adding oocd_ prefix to names, just more noise. > 2. What you did IS a functional change and this not my commit anymore. > This is why I dont fully like your way of working on a Gerrit - I have > introduced a change that I like so I give +1 in response to your -1 > comment, then you changed it the way I dont like it so I give -1 to > "my" change/commit. This is not exactly the way you and Peter describe > things to work. > It is quite normal for changes to go through revisions before being merged. You have told us that your work on swd support in OpenOCD is finished, and you requested other users to get involved. I have looked at your patches and found then to be confusing, out of order and containing a lot of noise, making review harder than it needs to be. My first task is to clean them up. Next i am going to look into the current issues. Cheers Spen ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
