On Thu, Jan 17, 2013 at 10:50 PM, Spencer Oliver <[email protected]> wrote: > On 16/01/13 22:21, Freddie Chopin wrote: >> W dniu 2013-01-16 22:57, Spencer Oliver pisze: >>> I have already started the rebase - >>> http://repo.or.cz/w/openocd/ntfreak.git/shortlog/refs/heads/libswd >>> >>> The next step is to squash some of the commits as noted in my comments >>> on gerrit, if you have time then feel free to continue. >> >> Well, in that case I think it's best for me to wait until you're done >> with your rebase and then I can do the squashing/merging stuff, right? >> > > I have rebased and squashed/cleaned a few commits. No functional changes > yet.
Spen, regarding the changes introduced in http://openocd.zylin.com/#/c/1077/ : 1. I dont agree to rename oocd_transport_allow() to allow_transports() and similar. I have named them to that convention on purpose. Please take a look at 'internals reorganization' thread and continue discussion over there if you like. 2. What you did IS a functional change and this not my commit anymore. This is why I dont fully like your way of working on a Gerrit - I have introduced a change that I like so I give +1 in response to your -1 comment, then you changed it the way I dont like it so I give -1 to "my" change/commit. This is not exactly the way you and Peter describe things to work. I am not responsible for changes introduced that way, I dont agree on them, although I am the initial commit author and things seems to go on my account... Best regards, Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
