[chromium-dev] Moving mailing lists from @googlegroups.com to @chromium.org

2010-01-20 Thread John Abd-El-Malek
This is a heads up that as part of moving all of our resources to chromium.org (and vanity!), I'll be switching our mailing lists to be under chromium.org today. I will send an email when it's done, but for now you may want to update your rules to be either googlegroups.com or chromium.orgso that

[chromium-dev] Re: Moving mailing lists from @googlegroups.com to @chromium.org

2010-01-20 Thread John Abd-El-Malek
managers can post) 3) send an email to the old list telling everyone that it's now disabled and that they must now post to the new list On Wed, Jan 20, 2010 at 11:08 AM, John Abd-El-Malek j...@chromium.orgwrote: This is a heads up that as part of moving all of our resources to chromium.org

[chromium-dev] Chromium-dev switched to @chromium.org

2010-01-20 Thread John Abd-El-Malek
Hello, The chromium-dev mailing list has now been switched to chromium-...@chromium.org. Please update your filters and address book accordingly. Existing members have been subscribed, with the exception of users who don't permit managers to add them to a group. You can visit the new group at

[chromium-dev] Re: Moving mailing lists from @googlegroups.com to @chromium.org

2010-01-20 Thread John Abd-El-Malek
receiving them. Everyone on chromium-dev also is marked for moderation without a reason. Trying to fix both of these issues. On Wed, Jan 20, 2010 at 1:14 PM, John Abd-El-Malek j...@chromium.org wrote: Just to explain to everyone the steps that I will follow. For each mailing list, I will: 1

Re: [chromium-dev] Best Practices when disabling tests?

2009-12-14 Thread John Abd-El-Malek
(this topic has been on my mind a lot, so here's my vent :) ) I think we shouldn't allow any test to be disabled without a bug to track it that includes an initially assigned owner. This shouldn't I've seen it happen too often that a test gets disabled to quickly turn the tree green, and it

Re: [chromium-dev] Best Practices when disabling tests?

2009-12-14 Thread John Abd-El-Malek
On Mon, Dec 14, 2009 at 10:42 AM, Drew Wilson atwil...@chromium.org wrote: They'll sometimes get disabled due to webkit updates, other times they'll get disabled due to other things (for example, we changed the valgrind bots to fail noisily if individual tests fail, regardless of whether they

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-11 Thread John Abd-El-Malek
at 11:02 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Dec 10, 2009 at 10:57 PM, Jeremy Orlow jor...@chromium.orgwrote: On Thu, Dec 10, 2009 at 10:25 PM, Peter Kasting pkast...@google.comwrote: On Thu, Dec 10, 2009 at 9:38 PM, John Abd-El-Malek j...@chromium.orgwrote: We disable

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-11 Thread John Abd-El-Malek
(adding Alice) Alice: do you have a rough estimate for how often we ask users to turn off the sandbox when debugging problems? Thanks On Fri, Dec 11, 2009 at 11:33 AM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Dec 10, 2009 at 11:34 PM, Darin Fisher da...@chromium.org wrote: I

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-11 Thread John Abd-El-Malek
that they shouldn't be running without sandbox but we need to give them a better way to figure out what's wrong so that they can continue to use it. -- Alice Lin | Google, Inc. | Senior Strategist, Consumer Operations | 650.253.6827 | a...@google.com On Fri, Dec 11, 2009 at 11:48 AM, John Abd-El-Malek j

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-10 Thread John Abd-El-Malek
On Thu, Dec 10, 2009 at 10:45 AM, Jonathan Dixon j...@chromium.org wrote: 2009/12/10 Brett Wilson bre...@chromium.org On Wed, Dec 9, 2009 at 4:24 PM, John Abd-El-Malek j...@chromium.org wrote: btw I searched the code, almost all the instances are in code from different repositories

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-10 Thread John Abd-El-Malek
On Thu, Dec 10, 2009 at 1:22 PM, Evan Stade est...@chromium.org wrote: On Thu, Dec 10, 2009 at 10:58 AM, Peter Kasting pkast...@google.comwrote: On Thu, Dec 10, 2009 at 10:45 AM, Jonathan Dixon j...@chromium.orgwrote: In essence: return DoWork(foo) #if defined(OS_POSIX)

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread John Abd-El-Malek
NaCl is the answer to all these problems... On Thu, Dec 10, 2009 at 5:15 PM, Jeremy Orlow jor...@google.com wrote: Or reject extensions that could be written without a NPAPI component. *ducks* On Thu, Dec 10, 2009 at 5:12 PM, Peter Kasting pkast...@google.comwrote: On Thu, Dec 10, 2009 at

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread John Abd-El-Malek
The goal is to expose all this through Pepper. On Thu, Dec 10, 2009 at 5:50 PM, Jeremy Orlow jor...@chromium.org wrote: Much of what can't be done on the web platform also can't be done inside the NaCl sandbox. On Thu, Dec 10, 2009 at 5:49 PM, John Abd-El-Malek jabdelma...@google.com

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-10 Thread John Abd-El-Malek
We disable --single-process and --in-process-plugins on release Google Chrome builds to avoid the support headache that it causes. I think we should do the same for --no-sandbox. On Thu, Dec 10, 2009 at 8:22 PM, Darin Fisher da...@chromium.org wrote: After reading the WebGL blog post today,

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-10 Thread John Abd-El-Malek
On Thu, Dec 10, 2009 at 10:57 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Dec 10, 2009 at 10:25 PM, Peter Kasting pkast...@google.comwrote: On Thu, Dec 10, 2009 at 9:38 PM, John Abd-El-Malek j...@chromium.orgwrote: We disable --single-process and --in-process-plugins on release

[chromium-dev] Thoughts on // NOLINT?

2009-12-09 Thread John Abd-El-Malek
Lately I've been seeing more and more // NOLINT added to the code. It's great that people are running lint to make sure that they're following the guidelines, but I personally find adding comments or gibberish to our code for tools that are supposed to make the code quality better happy/more

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-09 Thread John Abd-El-Malek
btw I searched the code, almost all the instances are in code from different repositories, like v8, gtest, gmock. I counted only 17 instances in Chrome's code. On Wed, Dec 9, 2009 at 4:08 PM, Evan Stade est...@chromium.org wrote: I didn't even know that I could disable the linter like that.

[chromium-dev] Re: Plugin Manager UI Proposal

2009-12-07 Thread John Abd-El-Malek
This is much needed, thanks for working on it :) Some notes: -Putting it in a url, but not having a menu item, removes much of the benefit since only a tiny percentage would be able to use it. -Checking that each plugin is up to date should be automatic and enabled for all users, just like our

[chromium-dev] Re: heads up: Rietveld reply by email isn't working

2009-11-22 Thread John Abd-El-Malek
Note: this should be working again now. We decided to put the issue numbers in the subject line like Mondrian (but at the end, as to not conflict with bug numbers which are put at the front of Python bug mail). On Thu, Nov 19, 2009 at 11:40 AM, John Abd-El-Malek j...@chromium.orgwrote

[chromium-dev] heads up: Rietveld reply by email isn't working

2009-11-19 Thread John Abd-El-Malek
There is a bug in App Engine with some new APIs that we're using. I'm working on a workaround with another outside contributor which will hopefully land in a day or two. Until then, if you care about your reply showing up on Rietveld, don't reply by email. -- Chromium Developers mailing list:

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread John Abd-El-Malek
toolstrip1). These tests don't run on Mac. We should run the tests on Linux to verify things look sane locally, too. No explanation for the odd results yet. Chase On Wed, Nov 18, 2009 at 3:08 PM, John Abd-El-Malek j...@chromium.orgwrote: I don't have an answer to that. The t_ref line didn't

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread John Abd-El-Malek
On Thu, Nov 19, 2009 at 2:17 PM, Matt Perry mpcompl...@chromium.org wrote: On Thu, Nov 19, 2009 at 2:14 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Nov 19, 2009 at 1:57 PM, Tony Chang t...@chromium.org wrote: For reasons unknown to me, this line jumped back up. It seems it's

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-18 Thread John Abd-El-Malek
Yep, that was my plan. I'm planning on doing the same thing for the rest of the child processes, and if I see any significant changes on the perf test (which I don't expect), I'll update the reference builds again. On Wed, Nov 18, 2009 at 6:46 AM, Brett Wilson bre...@google.com wrote: On Tue,

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-18 Thread John Abd-El-Malek
the extension_toolstrip1 test. Maybe the graph is pulling the wrong numbers? http://build.chromium.org/buildbot/perf/linux-release-hardy/startup/report.html?history=150graph=warm On Wed, Nov 18, 2009 at 9:53 AM, John Abd-El-Malek j...@chromium.orgwrote: Yep, that was my plan. I'm planning

[chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-17 Thread John Abd-El-Malek
Heads up to explain the sudden jump on Linux Startup perf test. I just submitted r32264 which makes opening and closing processes happen off the UI thread. Surprisingly enough, according to UMA stats these would take an average of 1s on Linux for the first renderer, and 100ms on Windows.

[chromium-dev] Re: Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-12 Thread John Abd-El-Malek
On Wed, Nov 11, 2009 at 10:40 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: On Thu, Nov 12, 2009 at 01:00, John Abd-El-Malek j...@chromium.org wrote: On Wed, Nov 11, 2009 at 1:22 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: To do that, I'd need to listen for BlacklistManager

Re: [chromium-dev] Re: Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-12 Thread John Abd-El-Malek
On Thu, Nov 12, 2009 at 11:45 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: On Thu, Nov 12, 2009 at 20:26, John Abd-El-Malek j...@chromium.org wrote: My question still stands: if this list is needed in order to process the first network request, why add extra complexity to RDH to make

Re: [chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-11-12 Thread John Abd-El-Malek
...@google.com wrote: On Thu, Oct 29, 2009 at 3:34 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Oct 29, 2009 at 3:23 PM, Finnur Thorarinsson fin...@chromium.org wrote: I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step

[chromium-dev] Re: Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-11 Thread John Abd-El-Malek
On Wed, Nov 11, 2009 at 1:22 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: Initially I got an advice to use PauseRequest and ResourceHandler to wait with servicing requests until all privacy blacklists are loaded. However, there are problems with that. When you look at

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-10 Thread John Abd-El-Malek
Enabling contribution to Chrome on Windows without having to purchase any software is very welcome, good job :) I looked at the steps, and as I'm sure you're thinking, if these can be incorporated into the gyp sln generation that would be ideal. On Mon, Nov 9, 2009 at 6:21 PM, Dominic Jodoin

Re: [chrome-devtools-team] Re: [chromium-dev] Re: How to log exceptions/console messages from shared worker context?

2009-11-08 Thread John Abd-El-Malek
On Sun, Nov 8, 2009 at 12:04 PM, Drew Wilson atwil...@chromium.org wrote: In base webkit (i.e. the default, single-process implementation of SharedWorkers), I route all of these errors back to the individual parent documents on the main thread, and log them via

[chromium-dev] Ensuring that all destructors of ref counted objects are private

2009-11-05 Thread John Abd-El-Malek
I've gone through the code and made all destructors of objects that derive from base::RefCounted or base::RefCountedThreadSafe private. This helps to catch corruption bugs at compile time. For classes that are derived from refcounted, make the destuctor protected and ensure that all derived

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread John Abd-El-Malek
On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.orgwrote: Over the last week, I've been making some changes to how threads are used in the browser process, with the goal of simplifying cross-thread access

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread John Abd-El-Malek
On Thu, Nov 5, 2009 at 1:42 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.orgwrote

[chromium-dev] Re: Singleton, LazyInstance, and testability

2009-11-04 Thread John Abd-El-Malek
On Tue, Nov 3, 2009 at 11:49 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: I encountered another problem related to Singletons in unit tests. PluginService is a Singleton, and it listens to extensions notifications. In one of my tests when I was using the extensions notifications the

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread John Abd-El-Malek
But this means that the person didn't use the trybot. I think we need to be harsher on people who commit with changes that didn't complete or failed on the trybot. They need to have a really good reason as to why they want to try their change on the buildbot and possibly delay many other

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-03 Thread John Abd-El-Malek
On Tue, Nov 3, 2009 at 12:03 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: On Tue, Nov 3, 2009 at 06:50, John Abd-El-Malek j...@chromium.org wrote: *The solution* 1+2: Use ChromeThread::PostTask and friends (i.e. PostDelayedTask, DeleteSoon, ReleaseSoon) which are safe and efficient

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-03 Thread John Abd-El-Malek
the media processing code off the render thread but we've been bitten using cached MessageLoops which have been destructed (usually on tab close when the render thread goes away). On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.orgwrote: Over the last week, I've been making some

[chromium-dev] Re: FYI: Linux interactive_ui_tests a bit hosed

2009-11-02 Thread John Abd-El-Malek
- if there are no UI tests in interactive_ui_tests). I also suggest bumping the priority of http://crbug.com/25997 to P1 and possibly marking it with FlakyTest label. On Mon, Nov 2, 2009 at 09:37, John Abd-El-Malek j...@chromium.org wrote: This is related to bug 25997. The tests are inherently flakey

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-02 Thread John Abd-El-Malek
...@google.com wrote: Cool! I could compare the builds before and after these changes to see what difference it makes. Of course it also prevents future issues. Huan On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.org wrote: Over the last week, I've been making some changes to how

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread John Abd-El-Malek
On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. I was just about to reply and say the same thing

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread John Abd-El-Malek
build, both on SSD etc. On Thu, Oct 29, 2009 at 14:51, John Abd-El-Malek j...@chromium.org wrote: On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger

[chromium-dev] git users and svn:eol-style

2009-10-29 Thread John Abd-El-Malek
Per the Chromium style guide ( http://dev.chromium.org/developers/coding-style), we require all new files to have the svn:eol-style property set. We even have a presubmit check for it in case you don't configure Subversion to automatically add them per the above previous link. git users seem to

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread John Abd-El-Malek
On Thu, Oct 29, 2009 at 5:31 PM, Evan Martin e...@chromium.org wrote: On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page http://dev.chromium.org/developers/coding-style then git will do the

[chromium-dev] Re: How to use PauseRequest

2009-10-23 Thread John Abd-El-Malek
Check out BufferedResourceHandler, it pauses requests until plugins are loaded (needed to know which mime types are available). On Fri, Oct 23, 2009 at 1:23 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: I'm going to use PauseRequest for privacy blacklists. It seems that I should create a

[chromium-dev] Re: [LTTF][WebKit Gardening]: Keeping up with the weeds.

2009-10-13 Thread John Abd-El-Malek
On Tue, Oct 13, 2009 at 3:46 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: Based on the feedback, it sounds like we need to take the approach with LTTF team adding more resources on cleaning up the bottom of the test_expectations file (i.e. stuff recently added by the gardeners). It is

[chromium-dev] Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
Saw this on slashdot: http://www.cs.toronto.edu/~bianca/papers/sigmetrics09.pdf The conclusion is an average of 25,000–75,000 FIT (failures in time per billion hours of operation) per Mbit. On my machine the browser process is usually 100MB, so that averages out to 176 to 493 error per year,

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
, Huan Ren hu...@google.com wrote: It will be helpful to get our own measurement on database failures. Carlos just added something like that. Huan On Tue, Oct 6, 2009 at 3:49 PM, John Abd-El-Malek j...@chromium.org wrote: Saw this on slashdot: http://www.cs.toronto.edu/~bianca/papers

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
On Tue, Oct 6, 2009 at 4:30 PM, Carlos Pizano c...@google.com wrote: On Tue, Oct 6, 2009 at 4:14 PM, John Abd-El-Malek j...@chromium.org wrote: I'm not sure how Carlos is doing it? Will we know if something is corrupt just on load/save? Many sqlite calls can return sqlite_corrupt

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
On Tue, Oct 6, 2009 at 5:09 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.orgwrote: On Tue, Oct 6, 2009 at 4:30 PM, Carlos Pizano c...@google.com wrote: On Tue, Oct 6, 2009 at 4:14 PM, John Abd-El-Malek j...@chromium.org wrote

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
problems. Personally, I don't care as much if my history or any other database is corrupted and I start from scratch. But random crashes that I can't isolate is something else. -scott On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.org wrote: On Tue, Oct 6, 2009 at 4

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
On Tue, Oct 6, 2009 at 5:16 PM, Scott Hess sh...@chromium.org wrote: On Tue, Oct 6, 2009 at 5:09 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.org wrote: On Tue, Oct 6, 2009 at 4:30 PM, Carlos Pizano c...@google.com wrote

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
On Tue, Oct 6, 2009 at 5:30 PM, Peter Kasting pkast...@google.com wrote: On Tue, Oct 6, 2009 at 3:49 PM, John Abd-El-Malek j...@chromium.orgwrote: Given that sqlite corruption means (repeated) crashing of the browser process, it seems this data heavily suggests we should separate sqlite code

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
On Tue, Oct 6, 2009 at 5:56 PM, Peter Kasting pkast...@google.com wrote: On Tue, Oct 6, 2009 at 5:53 PM, John Abd-El-Malek j...@chromium.orgwrote: If corruption in the in-memory URL database doesn't survive a crash (i.e. because it's recreated each time), It doesn't I'm not sure I

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread John Abd-El-Malek
This isn't about decreasing memory usage. It's about getting rid of nasty problems like the browser process crashing every startup because of a corrupt database and decreasing browser process crashes in general. I think it's fair that not everyone shares the same opinion, but I do hope that an

[chromium-dev] Who owns crash...@chromium.org and why is there so many updates from it?

2009-10-06 Thread John Abd-El-Malek
I got 21 emails in the last day for http://code.google.com/p/chromium/issues/detail?id=20915 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: Who owns crash...@chromium.org and why is there so many updates from it?

2009-10-06 Thread John Abd-El-Malek
at 6:51 PM, John Abd-El-Malek j...@chromium.org wrote: I got 21 emails in the last day for http://code.google.com/p/chromium/issues/detail?id=20915 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] Re: Jank: performance and animation frame rates

2009-10-02 Thread John Abd-El-Malek
On Fri, Oct 2, 2009 at 12:54 PM, Evan Stade est...@chromium.org wrote: We try to fire the timer rapidly, but if we get bogged down, it just won't fire until later; when it actually does fire, we update our state based on how much time has really passed instead of how many times the timer

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

2009-10-01 Thread John Abd-El-Malek
I built using the instructions on Windows 7 64 bit without installing another cygwin. On Thu, Oct 1, 2009 at 4:03 PM, vha14 vuh...@gmail.com wrote: So it looks like I need to install Cygwin separately before I can build Chrome? If so this should be added to the Windows build instruction

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

2009-10-01 Thread John Abd-El-Malek
(1.5.25-15), copying sh.exe and bash.exe over to src\third_party\cygwin\bin. So it may be a good idea to check in this Cygwin version. On Oct 1, 2009 4:43pm, John Abd-El-Malek j...@chromium.org wrote: I built using the instructions on Windows 7 64 bit without installing another cygwin

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-23 Thread John Abd-El-Malek
! Do we have a Python/gcl/rietveld expert who can tackle this? :DG On Wed, Sep 23, 2009 at 9:49 AM, John Abd-El-Malek j...@chromium.org wrote: I didn't know this was possible. It seems it will get a lot more usage if it just works, i.e. the try script grabs these settings automatically

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-23 Thread John Abd-El-Malek
are generates when in the WebKit directory. Marc-Antoine knows this best, so I'm handing it off. On Wed, Sep 23, 2009 at 10:13 AM, Dimitri Glazkov dglaz...@google.comwrote: BTW, I trying to be snarky in my request. More like begging :) :DG On Wed, Sep 23, 2009 at 10:08 AM, John Abd-El-Malek j

[chromium-dev] Problem with gyp every time v8 updates their branch

2009-09-23 Thread John Abd-El-Malek
Every time v8 team updates which branch is the one that's used in Chrome, gclient sync fails on Windows. The error is below. running 'svn update a:\chrome2\src\tools\tryserver' in 'a:\chrome2' At revision 3275. Error: Can't switch the checkout to http://v8.googlecode.com/svn/tr...@2966;

[chromium-dev] When disabling a test, please assign to whoever wrote it

2009-09-22 Thread John Abd-El-Malek
It only takes a few moments to figure out this information, and ensures that the bug lands on the right person's desk. http://src.chromium.org/viewvc/chrome/trunk/src/ can show who wrote the initial test For commits before we moved to the open source repository, look at

[chromium-dev] Re: debugging the browser started by UI tests

2009-09-22 Thread John Abd-El-Malek
Agreed, we should have a --browser-startup-dialog that's added to BrowserMain. ui_tests can then pass it and --renderer-startup-dialog, plugin-startup-dialog, in-process-plugins, --single-process along if they're specified. On Tue, Sep 22, 2009 at 4:03 PM, Scott Violet s...@chromium.org wrote:

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-22 Thread John Abd-El-Malek
On Tue, Sep 22, 2009 at 6:06 PM, Dimitri Glazkov dglaz...@google.comwrote: Today wasn't a happy day for p...@. He did a seemingly innocuous roll that broke the world: selenium, ui tests, layout tests. I am sure it was stressful and probably added unnecessary gray to his hair. Stuff like

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread John Abd-El-Malek
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote: I think we need to re-consider our practice of shipping beta/stable browsers with experimental features hidden behind flags--at least when they have any side-effects in JavaScript. An example of where this has bitten us

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread John Abd-El-Malek
On Mon, Sep 21, 2009 at 3:43 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.orgwrote: I think we need to re-consider our practice of shipping beta/stable

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread John Abd-El-Malek
On Mon, Sep 21, 2009 at 3:59 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Sep 21, 2009 at 3:51 PM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Sep 21, 2009 at 3:43 PM, Jeremy Orlow jor...@chromium.orgwrote: On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek j

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
For reference, something similar is done for popups: void NPN_PushPopupsEnabledState(NPP instance, NPBool enabled); void NPN_PopPopupsEnabledState(NPP instance); Perhaps we can do the same thing here: void NPN_PushPluginHangDetectorState(NPP instance, NPBool enabled); void NPN_Pop

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 3:44 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.orgwrote: I presume you're referring to Chrome extensions? I don't see the advantage of making this depend on the plugin being distributed via extensions

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:01 PM, Mike Morearty m...@morearty.com wrote: On Fri, Sep 11, 2009 at 3:54 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:37 PM, John Abd-El-Malek j...@chromium.orgwrote: For reference, something similar is done for popups: void

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:32 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 7:31 PM, John Abd-El-Malek j...@chromium.orgwrote: If this sounds good to you, the next step would be getting a broader discussion with other browser vendors on the plugin-futures mailing list

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
Abd-El-Malek j...@chromium.orgwrote: On Fri, Sep 11, 2009 at 4:03 PM, Mike Morearty m...@morearty.com wrote: On Fri, Sep 11, 2009 at 3:44 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.orgwrote: I presume you're referring

[chromium-dev] Re: autolinking BUG= lines in Rietveld

2009-09-10 Thread John Abd-El-Malek
talking about when it is viewed in Rietveld?What about when it is actually committed, can the change log be tweaked that way, automatically, too? That would be nice when reading change logs. Thank you! ☆PhistucK On Thu, Sep 10, 2009 at 05:01, John Abd-El-Malek j...@chromium.org wrote

[chromium-dev] Re: memory leak in render_thread_unittest

2009-09-03 Thread John Abd-El-Malek
These leaks have always existed in the unit tests. They don't happen in Chrome builds since the posted tasks always get a chance to run on different thread where they clean up. But in unit tests that doesn't (always) happen. It's been low priority for me to look at because it's not a real leak,

[chromium-dev] Re: memory leak in render_thread_unittest

2009-09-03 Thread John Abd-El-Malek
. Thanks. On Thu, Sep 3, 2009 at 10:53 AM, John Abd-El-Malek j...@chromium.orgwrote: These leaks have always existed in the unit tests. They don't happen in Chrome builds since the posted tasks always get a chance to run on different thread where they clean up. But in unit tests that doesn't

[chromium-dev] Re: Long (exciting?) writeup on improving Mac New Tab Performance (not entirely Mac-specific)

2009-08-31 Thread John Abd-El-Malek
On Mon, Aug 31, 2009 at 4:50 PM, Scott Hess sh...@chromium.org wrote: On Mon, Aug 31, 2009 at 8:56 AM, Mark Mentovaim...@chromium.org wrote: Well, that annoying throbber is still chewing up time, causing some amount of UI loop contention while the images, thumbnails, and icons are

[chromium-dev] Re: Long (exciting?) writeup on improving Mac New Tab Performance (not entirely Mac-specific)

2009-08-31 Thread John Abd-El-Malek
On Mon, Aug 31, 2009 at 9:57 AM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Aug 31, 2009 at 4:50 PM, Scott Hess sh...@chromium.org wrote: On Mon, Aug 31, 2009 at 8:56 AM, Mark Mentovaim...@chromium.org wrote: Well, that annoying throbber is still chewing up time, causing some amount

[chromium-dev] Re: [linux] plugin paths

2009-08-28 Thread John Abd-El-Malek
Can't we blacklist nspluginwrapper, and use the same logic that it uses to find the real plugins? On Fri, Aug 28, 2009 at 11:01 AM, Evan Martin e...@chromium.org wrote: Right now our plugin loading code matches Firefox in the search path order. 1 $MOZ_PLUGIN_PATH 2 ~/.mozilla/plugins 3

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-27 Thread John Abd-El-Malek
On Thu, Aug 27, 2009 at 11:57 AM, hap 497 hap...@gmail.com wrote: On Mon, Aug 24, 2009 at 1:26 PM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Aug 24, 2009 at 1:06 PM, Brett Wilson bre...@chromium.orgwrote: On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote: Thanks

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread John Abd-El-Malek
I think this is one of those things that aren't worth the effort. Brett's change was also to fix other bugs, so it wasn't just for this. I'd be surprised if people spend time to fix bugs solely for this. On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissman a...@google.com wrote: I've heard people

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread John Abd-El-Malek
On Wed, Aug 26, 2009 at 12:41 PM, Darin Fisher da...@chromium.org wrote: On Wed, Aug 26, 2009 at 12:16 PM, Brett Wilson bre...@chromium.orgwrote: On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissmana...@google.com wrote: I've heard people proclaim the principle of being able to copy a profile

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread John Abd-El-Malek
On Wed, Aug 26, 2009 at 1:20 PM, Dan Kegel d...@kegel.com wrote: On Wed, Aug 26, 2009 at 12:59 PM, Jeremy Orlowjor...@chromium.org wrote: I really like the idea of being able to move people between operating systems and just bringing the profile along without having to export and

[chromium-dev] Re: Splitting up chrome.dll

2009-08-25 Thread John Abd-El-Malek
This is very cool work, it'll especially be useful for outside developers who don't have our beefy machines :) Would it be possible to get a sense of what percentage of chrome.dll is due to our code (i.e. base, net, chrome) vs third party (i.e. everything in \third_party including webkit)?

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-24 Thread John Abd-El-Malek
There's one ResourceDispatcherHost for all renderers (but there is one ResourceMessageFilter per renderer process). That graph shows a connection between the filter (ResourceMessageFilter) and the ResourceDispatcherHost, but it's the former that has a pointer to the latter. RDH doesn't have a

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-24 Thread John Abd-El-Malek
On Mon, Aug 24, 2009 at 1:06 PM, Brett Wilson bre...@chromium.org wrote: On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote: Thanks. But the picture in the document shows there is only 1 ResourceDispatcherHost and there are 2 Renderer Processes:

[chromium-dev] PSA: do not include X_messages.h in other headers

2009-08-20 Thread John Abd-El-Malek
Including files like render_messages.h and automation_messages.h from other header files is unnecessary and slows down the build (adds about ~100K lines of headers to each cc file). Last time I removed all these occurrences, it improved the build time by 15%. Looks like a few more crept in now,

[chromium-dev] Re: PSA: do not include X_messages.h in other headers

2009-08-20 Thread John Abd-El-Malek
going to write a presubmit check for that. On Thu, Aug 20, 2009 at 11:12, John Abd-El-Malek j...@chromium.org wrote: Including files like render_messages.h and automation_messages.h from other header files is unnecessary and slows down the build (adds about ~100K lines of headers to each cc

[chromium-dev] Re: PSA: do not include X_messages.h in other headers

2009-08-20 Thread John Abd-El-Malek
at once) it miight be faster. That said, it would surprise me if this was adding more than a second or two to the time. I bet most of it is waiting on other servers and such. On Thu, Aug 20, 2009 at 11:20 AM, John Abd-El-Malek j...@chromium.org wrote: Great! Please try to add

[chromium-dev] Re: PSA: do not include X_messages.h in other headers

2009-08-20 Thread John Abd-El-Malek
and such. This gives me an idea: I'll add the time it takes to run presubmit checks to the output, so we can see how long it's taking. On Thu, Aug 20, 2009 at 11:20 AM, John Abd-El-Malek j...@chromium.orgwrote: Great! Please try to add this to an existing check, or do it in a way that doesn't involve

[chromium-dev] Re: Plugin control flow and race conditions

2009-08-18 Thread John Abd-El-Malek
On Mon, Aug 17, 2009 at 11:43 AM, bsmedberg bsmedb...@gmail.com wrote: At Mozilla we're currently working on implementing multi-process plugin hosts similar to the model used by Chromium. However, we're having trouble working through the many potential race conditions introduced by having

[chromium-dev] Re: Can't edit others' codereviews?

2009-08-18 Thread John Abd-El-Malek
On Tue, Aug 18, 2009 at 5:37 AM, Evan Martin e...@chromium.org wrote: On Sat, Aug 15, 2009 at 11:44 PM, Nico Webertha...@chromium.org wrote: `git cl patch` reuses existing issues, so when landing stuff for other people, I used to edit the issue on codereview to add Patch by

[chromium-dev] Re: running reliability tests

2009-08-18 Thread John Abd-El-Malek
The information on how to do this is currently on the internal wiki, although it seems there's no reason it shouldn't be moved to the public wiki (not it :) ). http://wiki.corp.google.com/twiki/bin/view/Main/ChromeDebuggingChromeBotCrashes On Tue, Aug 18, 2009 at 3:42 PM, James Hawkins

[chromium-dev] Re: Can't edit others' codereviews?

2009-08-17 Thread John Abd-El-Malek
, 2009 at 3:14 PM, Mark Mentovai m...@chromium.org wrote: John Abd-El-Malek wrote: Intentional but I have a TODO in the Chromium branch of Rietveld to update this. I just synced ~60 changes from trunk to our branch, and now we get a close button to the left of each issue. Since everyone

[chromium-dev] Re: Can't edit others' codereviews?

2009-08-16 Thread John Abd-El-Malek
Intentional but I have a TODO in the Chromium branch of Rietveld to update this. I just synced ~60 changes from trunk to our branch, and now we get a close button to the left of each issue. Since everyone with a @chromium account could edit an issue, I thought it was too easy to accidentally

[chromium-dev] Re: gcl change that you should be aware of

2009-08-06 Thread John Abd-El-Malek
whoa, please revert this change. if I have a big changelist, now every time I run gcl I have to expend effort to make sure no new files crept in. this will lead to more build failures as people check in other files accidently. On Wed, Aug 5, 2009 at 5:56 PM, Anthony LaForge lafo...@google.com

[chromium-dev] Re: Running UI test in parallel (experimental)

2009-08-06 Thread John Abd-El-Malek
This is very cool, but I ran into a few problems when I tried to run it: a:\chrome2\src\chrometools\test\smoketests.py --tests=ui You must have your local path of trunk/src/tools/python added to your PYTHONPATH. Traceback (most recent call last): File

[chromium-dev] Re: Design Doc: out of process (v8) proxy resolving

2009-07-29 Thread John Abd-El-Malek
The plug-in sandbox is too weak to be robust, see the other thread about it. As long as it has access to HWNDs, it's very easy to break out of it. On Wed, Jul 29, 2009 at 10:43 AM, Adam Barth aba...@chromium.org wrote: I wonder if we could use something like the plug-in sandbox for the main

[chromium-dev] Re: Quota UI for LocalStorage (and others in the future)

2009-07-29 Thread John Abd-El-Malek
On Tue, Jul 28, 2009 at 8:40 PM, Jeremy Orlow jor...@chromium.org wrote: I'm starting to think ahead to how quotas will work with LocalStorage (and I assume database and maybe even AppCache). To begin with, I'll probably just set a fixed quota (5mb is pretty standard), but some apps will

  1   2   >