Re: [concordance-devel] Harmony 300

2012-09-29 Thread Phil Dibowitz
, but at a glance it looks reasonable. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter

Re: [concordance-devel] Harmony 300

2012-09-29 Thread Phil Dibowitz
On 09/29/2012 04:58 PM, Phil Dibowitz wrote: On 08/19/2012 02:52 PM, Scott Talbert wrote: Review/comment appreciated. If anyone wanted to try this against their 300, that would be helpful too. Mainly just to see if the GetIdentity and Reset functions work. Did a quick run through. I need

Re: [concordance-devel] Congruity Port to New API

2012-10-21 Thread Phil Dibowitz
On 10/19/2012 08:20 PM, Scott Talbert wrote: On Sun, 15 Jul 2012, Scott Talbert wrote: On Sun, 15 Jul 2012, Phil Dibowitz wrote: --- libconcord/libconcord.h 22 Mar 2012 08:50:20 - 1.22.2.15 +++ libconcord/libconcord.h 20 Jun 2012 03:53:26 - @@ -163,7 +163,6 @@ int

Re: [concordance-devel] Harmony 300

2012-10-21 Thread Phil Dibowitz
, + 0x04, (len 0xFF00) 24, (len 0x00FF) 16, heh. OK, I took a more careful read through the code, and this looks pretty sane. The protocol is a but unfortunate, but such is life. What's the operational status? -- Phil Dibowitz p...@ipom.com Open

Re: [concordance-devel] 688 Firmware Updates

2012-11-11 Thread Phil Dibowitz
Hey Scott, The parsing patch looks fine, but why are you ignoring INVALID_CONFIG as an error? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who

Re: [concordance-devel] Congruity Port to New API

2012-11-11 Thread Phil Dibowitz
of stages? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who

Re: [concordance-devel] Congruity Port to New API

2012-11-13 Thread Phil Dibowitz
time. Can congruity handle that first meta call back without it's arg? (I know, this is crazytown). -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com

Re: [concordance-devel] Congruity Port to New API

2013-01-02 Thread Phil Dibowitz
version. Having two branches is... tiring. I want to get everyone moved over and have all the many remotes we've added support for see the world. So I'll be checking for patches more regularly, I hope. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs

Re: [concordance-devel] Congruity Port to New API

2013-01-06 Thread Phil Dibowitz
On 01/03/2013 07:59 PM, Scott Talbert wrote: On Wed, 2 Jan 2013, Phil Dibowitz wrote: Unfortunately, no it cannot. It needs to be able to store/act on that information, and it can't do that without its pointer. Did you have any further thoughts on this? I suppose we could just add

Re: [concordance-devel] 688 Firmware Updates

2013-01-07 Thread Phil Dibowitz
On 01/06/2013 11:29 AM, Scott Talbert wrote: On Sun, 6 Jan 2013, Phil Dibowitz wrote: So this all looks fine but this: -reset_remote(cb, cb_arg); +if ((err = reset_remote(cb, cb_arg))) +return err; I think we did this because some remotes don't reset right and we

Re: [concordance-devel] 688 Firmware Updates

2013-01-12 Thread Phil Dibowitz
s...@techie.net Committed, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't

Re: [concordance-devel] Congruity Port to New API

2013-01-12 Thread Phil Dibowitz
On 01/12/2013 05:52 PM, Scott Talbert wrote: On Sat, 12 Jan 2013, Phil Dibowitz wrote: Applied. Thanks for all your work on this! My pleasure. Now, what do you think remains to be done in order to get zwave_work_branch out to the world? I'll do a bit more testing with congruity

Re: [concordance-devel] Reset Fix Patch

2013-01-14 Thread Phil Dibowitz
On 01/13/2013 04:43 PM, Scott Talbert wrote: This patch fixes the issue where some remotes do not get a successful return from reset(). Why the change from usb_strerror() to strerror() ? -- Phil Dibowitz p...@ipom.com Open Source software and tech docs

Re: [concordance-devel] Reset Fix Patch

2013-01-28 Thread Phil Dibowitz
. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind

Re: [concordance-devel] Congruity Port to New API

2013-01-28 Thread Phil Dibowitz
On 01/16/2013 08:42 PM, Scott Talbert wrote: On Sat, 12 Jan 2013, Phil Dibowitz wrote: Also, looking in my 'pending patches' directory, there are still a couple there that haven't been merged: the Harmony 300 patch (v4) and the patch to do config dumping for zwave (v6). Although

Re: [concordance-devel] Congruity Port to New API

2013-02-05 Thread Phil Dibowitz
THIS. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind

Re: [concordance-devel] Congruity Port to New API

2013-02-05 Thread Phil Dibowitz
On 01/16/2013 08:42 PM, Scott Talbert wrote: On Sat, 12 Jan 2013, Phil Dibowitz wrote: Also, looking in my 'pending patches' directory, there are still a couple there that haven't been merged: the Harmony 300 patch (v4) and the patch to do config dumping for zwave (v6). Although

Re: [concordance-devel] Harmony 300

2013-03-29 Thread Phil Dibowitz
and drop to 4-space indentation I'm going to be moving a smaller project to git on SF and see how I like their implementation... but I don't want my projects split across too many different configurations, so I wanna make sure I like something before I move everything to it. -- Phil Dibowitz

Re: [concordance-devel] mh/300 code review

2013-03-29 Thread Phil Dibowitz
took the day off today (birthday holiday) to catch up on patches, and I don't have any major travel or presentations for a month, so I should be able to keep up. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http

Re: [concordance-devel] mh/300 code review

2013-03-29 Thread Phil Dibowitz
, so it may or may not be available for download later. However, if you're interested, I'm keynoting ChefConf which will also be streamed and just found out I got accepted to OSCon. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace

Re: [concordance-devel] Harmony 300

2013-03-29 Thread Phil Dibowitz
On 03/29/2013 03:18 PM, Scott Talbert wrote: On Fri, 29 Mar 2013, Phil Dibowitz wrote: I'm going to be moving a smaller project to git on SF and see how I like their implementation... but I don't want my projects split across too many different configurations, so I wanna make sure I like

Re: [concordance-devel] mh/300 code review

2013-04-03 Thread Phil Dibowitz
it's known config dumping doesn't work on 300, for sure. That patch is being held until after the release. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http

Re: [concordance-devel] mh/300 code review

2013-04-03 Thread Phil Dibowitz
] Error 2 Yep. Phil, it looks like remote_mh.cpp didn't make it into CVS. Whoops. Fixed, sorry. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com

Re: [concordance-devel] mh/300 code review

2013-04-03 Thread Phil Dibowitz
On 04/03/2013 08:45 AM, Phil Dibowitz wrote: Whoops. Fixed, sorry. Actually, while libconcord builds now, concordance doesn't: [phil@rider concordance]$ make make all-am make[1]: Entering directory `/home/phil/build/cvs/concordance_zwave/concordance' gcc -DHAVE_CONFIG_H -I.-Wall -ansi

Re: [concordance-devel] mh/300 code review

2013-04-03 Thread Phil Dibowitz
On 04/03/2013 09:01 AM, Scott Talbert wrote: On Wed, 3 Apr 2013, Phil Dibowitz wrote: Actually, while libconcord builds now, concordance doesn't: [phil@rider concordance]$ make make all-am make[1]: Entering directory `/home/phil/build/cvs/concordance_zwave/concordance' gcc

Re: [concordance-devel] mh/300 code review

2013-04-03 Thread Phil Dibowitz
On Tue, Apr 02, 2013 at 11:36:47PM -0700, Phil Dibowitz wrote: On 04/02/2013 11:30 PM, Bart Cerneels wrote: Correct me if I'm wrong: This is supposed to support the logitech harmony One? I can test that one and the MyHarmony 300. Anything known not to work/supposed to work? We need

Re: [concordance-devel] mh/300 code review

2013-04-03 Thread Phil Dibowitz
On Wed, Apr 03, 2013 at 07:23:38PM -0400, Scott Talbert wrote: On Wed, 3 Apr 2013, Phil Dibowitz wrote: Hmm. I did make clean, but I went back and did 'make distclean' and re-ran autoreconf, and then re configure/make/make installed and it works fine. Bizarre. I'll test my 880 and my

Re: [concordance-devel] mh/300 code review

2013-04-04 Thread Phil Dibowitz
cannot test this. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those

Re: [concordance-devel] mh/300 code review

2013-04-05 Thread Phil Dibowitz
On 04/05/2013 06:09 AM, Scott Talbert wrote: On Thu, 4 Apr 2013, Phil Dibowitz wrote: * udev stuff doesn't work for me, needed sudo What version of Debian are you running? Squeeze? Sid. 895 Identity: PASS Reset: N/A Config dump: Output issues: Requesting identity: 100

Re: [concordance-devel] mh/300 code review

2013-04-05 Thread Phil Dibowitz
\ - $(DESTDIR)$(libdir)/udev/ + $(DESTDIR)$(UDEVLIBDIR)/udev/ install_udev: udev install_udev_generic -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http

Re: [concordance-devel] mh/300 code review

2013-04-05 Thread Phil Dibowitz
On 04/05/2013 10:48 AM, Scott Talbert wrote: On Fri, 5 Apr 2013, Phil Dibowitz wrote: Here's the best diff I can come up with to fix it. --- Makefile.am 3 Apr 2013 06:13:55 - 1.11.2.7 +++ Makefile.am 5 Apr 2013 16:36:56 - @@ -7,21 +7,23 @@ operationfile.cpp

Re: [concordance-devel] mh/300 code review

2013-04-05 Thread Phil Dibowitz
On 04/05/2013 10:50 AM, Scott Talbert wrote: On Fri, 5 Apr 2013, Phil Dibowitz wrote: On 04/05/2013 06:09 AM, Scott Talbert wrote: On Thu, 4 Apr 2013, Phil Dibowitz wrote: * udev stuff doesn't work for me, needed sudo What version of Debian are you running? Squeeze? Sid. Did you try

Re: [concordance-devel] mh/300 code review

2013-04-06 Thread Phil Dibowitz
On 04/05/2013 03:51 PM, Scott Talbert wrote: On Fri, 5 Apr 2013, Phil Dibowitz wrote: * udev stuff doesn't work for me, needed sudo What version of Debian are you running? Squeeze? Sid. Did you try this again after you figured out we were putting the udev rules in the wrong place

Re: [concordance-devel] mh/300 code review

2013-04-06 Thread Phil Dibowitz
On 04/05/2013 02:39 PM, Scott Talbert wrote: On Fri, 5 Apr 2013, Phil Dibowitz wrote: .. took some debugging to get the udev dhcp stuff to work right. with a --prefix=/usr we install udev stuff in /usr/lib/udev but it should be in /lib/udev (at least in Debian) - but after that it worked

Re: [concordance-devel] mh/300 code review

2013-04-07 Thread Phil Dibowitz
On 04/06/2013 08:45 PM, Scott Talbert wrote: On Sat, 6 Apr 2013, Phil Dibowitz wrote: So, I'm assuming this is going to show no permissions for your user. It looks like what udev-acl does is that is parses /var/run/ConsoleKit/database and if it finds an entry in there that indicates

Re: [concordance-devel] mh/300 code review

2013-04-08 Thread Phil Dibowitz
On 04/07/2013 06:52 PM, Scott Talbert wrote: On Sun, 7 Apr 2013, Phil Dibowitz wrote: Well, it sounds like xdm doesn't have ConsoleKit support, so that is probably the problem: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=615020 So, maybe for your case, the recommended approach would

Re: [concordance-devel] mh/300 code review

2013-04-08 Thread Phil Dibowitz
What do you think of the attached patch? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind

Re: [concordance-devel] mh/300 code review

2013-04-09 Thread Phil Dibowitz
with the other stuff when I prep the release. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't

Re: [concordance-devel] Preparing for the 1.0 release!

2013-04-10 Thread Phil Dibowitz
On 04/09/2013 09:40 PM, Phil Dibowitz wrote: OK all - we're almost ready for 1.0!! (Holy hell I hate CVS.) OK, so I have now: * Built a new branch called non_zwave_support_branch. I doubt it'll be used, but if we needed to fix 0.24 we would do it here. * Merged zwave_work_branch

Re: [concordance-devel] Preparing for the 1.0 release!

2013-04-16 Thread Phil Dibowitz
On 04/16/2013 05:40 PM, Scott Talbert wrote: On Tue, 16 Apr 2013, Phil Dibowitz wrote: Does this look right to you for 1.0? http://www.phildev.net/concordance/supported_models.shtml Yep, just a couple of updates: * MH is Arch 16 * The One is Arch 12 * 900/1000/1100 (I don't know about

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-04-17 Thread Phil Dibowitz
+jake, who I should have known isn't on the list, because I had to approve his post. Jake, you should join the list. :) On 04/17/2013 09:12 AM, Phil Dibowitz wrote: On 04/16/2013 11:57 AM, Jake wrote: First off, thanks for all your hard work on Concordance - I've been using it for awhile now

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-04-17 Thread Phil Dibowitz
access to windows boxes with build tools via, say, rdesktop. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-04-18 Thread Phil Dibowitz
! Thanks. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-04-19 Thread Phil Dibowitz
On 04/19/2013 06:04 AM, Scott Talbert wrote: On Thu, 18 Apr 2013, Phil Dibowitz wrote: On 04/17/2013 08:55 PM, Scott Talbert wrote: Well, it looks like you can get the express version of Visual Studio for free. Yeah, but I don't own a Windows box. :) Well, what I really meant is one can

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-04-22 Thread Phil Dibowitz
On 04/19/2013 10:25 AM, Scott Talbert wrote: On Fri, 19 Apr 2013, Phil Dibowitz wrote: Anyway, one of the things left to deal with is libzzip. Do we: a) Embed a copy of libzzip (and zlib, which libzzip requires) b) Require users to download libzzip and zlib (and put them somewhere) I

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-04-23 Thread Phil Dibowitz
Nice work, thanks! +m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) What's that? +#define sleep(x) Sleep((x) * 1000) +#define snprintf _snprintf Shouldn't those be guarded with #ifdef WIN23 ? Index: libconcord/win/libconcord.def This file makes me angry everytime I see it. -- Phil Dibowitz

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-04-23 Thread Phil Dibowitz
On Tue, Apr 23, 2013 at 12:23:28PM -0400, Scott Talbert wrote: On Tue, 23 Apr 2013, Phil Dibowitz wrote: +m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) What's that? It is something I had to add in order to get the latest version of autoconf to work. I added the ifdef so it will work on older

Re: [concordance-devel] Concordance 1.0 help

2013-04-28 Thread Phil Dibowitz
/INSTALL.mac. Then compile concordance by using the instructions in concordance/INSTALL.mac. I have a mac, and can try to test this week as well. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net

Re: [concordance-devel] Concordance 1.0 help

2013-04-30 Thread Phil Dibowitz
work: [phil@foobar concordance]$ sudo concordance -vi Concordance 1.0 Copyright 2007 Kevin Timmerman and Phil Dibowitz This software is distributed under the GPLv3. ERROR: Couldn't initializing libconcord: Error connecting or finding the remote NOTE: if you recently plugged in your remote and you

Re: [concordance-devel] Concordance 1.0 help

2013-04-30 Thread Phil Dibowitz
On Tue, Apr 30, 2013 at 09:12:20AM -0700, Phil Dibowitz wrote: That's with my 890 and my 880... the Info.plist file may need a new format or something... I also remember when I wrote the mac support, the libusb stuff was pretty shaky... Sonofabitch: http://www.libusb.org/ticket/89 Most

[concordance-devel] Move to git...

2013-04-30 Thread Phil Dibowitz
is to not touch it until I bless git the gold standard. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who

Re: [concordance-devel] Building Concordance 1.0 in OS X

2013-05-05 Thread Phil Dibowitz
to connect for 1 seconds const char * const http_get_cmd = \ -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel

Re: [concordance-devel] Building Concordance 1.0 in OS X

2013-05-05 Thread Phil Dibowitz
On 05/05/2013 08:15 PM, Phil Dibowitz wrote: On 05/05/2013 07:57 PM, Phil Dibowitz wrote: I also needed to patch libconcord to compile on mac: Actually I've gone ahead and committed this to our git repo. FWIW, I installed pkgconfig from here: http://macpkg.sourceforge.net/ It's

[concordance-devel] libhid patch

2013-05-06 Thread Phil Dibowitz
if it actually works... someone wanna try this (in Linux, it's not yet ready for Mac), and lemme know how it goes? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http

Re: [concordance-devel] libhid patch

2013-05-07 Thread Phil Dibowitz
On 05/07/2013 08:28 AM, Scott Talbert wrote: On Mon, 6 May 2013, Phil Dibowitz wrote: Attached is a super rough (did it in 20 minutes at the airport) patch to move concordance to libhid, which is required to make things work in Mac, and may also make windows support more consistent. Maybe

Re: [concordance-devel] libhid patch

2013-05-09 Thread Phil Dibowitz
On Tue, May 07, 2013 at 11:28:06AM -0400, Scott Talbert wrote: On Mon, 6 May 2013, Phil Dibowitz wrote: Attached is a super rough (did it in 20 minutes at the airport) patch to move concordance to libhid, which is required to make things work in Mac, and may also make windows support

Re: [concordance-devel] libhid patch

2013-05-09 Thread Phil Dibowitz
On Thu, May 09, 2013 at 10:53:27AM -0400, Scott Talbert wrote: On Thu, 9 May 2013, Phil Dibowitz wrote: I can try it. Are you proposing moving the Linux build to this? If so, I would be a little hesistant, as it didn't look like hidapi is packaged in many distributions. BTW, I sent

Re: [concordance-devel] libhid patch

2013-05-10 Thread Phil Dibowitz
On Fri, May 10, 2013 at 12:07:37AM -0400, Scott Talbert wrote: On Tue, 7 May 2013, Phil Dibowitz wrote: Anyway, as of this point, it compiles, but I'm on a laptop in an airport and have no idea if it actually works... someone wanna try this (in Linux, it's not yet ready for Mac

Re: [concordance-devel] libhid patch

2013-05-10 Thread Phil Dibowitz
On Fri, May 10, 2013 at 08:54:42AM -0400, Scott Talbert wrote: On Fri, 10 May 2013, Phil Dibowitz wrote: Anyway, as of this point, it compiles, but I'm on a laptop in an airport and have no idea if it actually works... someone wanna try this (in Linux, it's not yet ready for Mac

Re: [concordance-devel] libhid patch

2013-05-13 Thread Phil Dibowitz
On Fri, May 10, 2013 at 08:54:42AM -0400, Scott Talbert wrote: On Fri, 10 May 2013, Phil Dibowitz wrote: Anyway, as of this point, it compiles, but I'm on a laptop in an airport and have no idea if it actually works... someone wanna try this (in Linux, it's not yet ready for Mac

Re: [concordance-devel] libhid patch

2013-05-13 Thread Phil Dibowitz
On Mon, May 13, 2013 at 09:17:42AM -0400, Scott Talbert wrote: On Mon, 13 May 2013, Phil Dibowitz wrote: OK, I rebased it on the current HEAD and added a wee-bit of debugging. Can you try again and compile with debug on? I'll give it a try later. It *might* be a problem with hidapi

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-05-14 Thread Phil Dibowitz
with the WinHID code that I ran into while testing an MH remote under Windows. Phil, did you have any more comments on the Windows build fix patch (v3)? If not, it could probably be merged? I must have missed that... I'll look for it tomorrow (it's late here, I'm in London). -- Phil Dibowitz

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-05-15 Thread Phil Dibowitz
support for a bunch of build environments which is fine, but a. we should remove the related project files b. we should not list one of the following in the readme if there's only one option :) 3. Why the extra abstraction in HID_WriteReport in winhid.cpp? -- Phil Dibowitz

Re: [concordance-devel] libhid patch

2013-05-15 Thread Phil Dibowitz
? There's not even an hid_write in their docs. hid_interrupt_write is the closest I see. +int err = hid_read_timeout(h_dev, data, USB_PACKET_LENGTH, timeout); Same here. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace

[concordance-devel] Status

2013-06-06 Thread Phil Dibowitz
Just FYI, I haven't completely fallen off the face of the planet. I was in London for a month, and I'm heading off to Detroit for Orion Festival today, be back Monday. After that I should be able to start catching up on email and patches. And it'll be easier now that we're on git. :) -- Phil

Re: [concordance-devel] [Patch] Fix Automake

2013-06-23 Thread Phil Dibowitz
Applied, but I amended your commit message to explain each one (after a bit of research). -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you

Re: [concordance-devel] [Patch] Add a gitignore

2013-06-23 Thread Phil Dibowitz
On 05/15/2013 08:34 PM, Scott Talbert wrote: Add a gitignore so git will ignore object and other files. Committed. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-06-23 Thread Phil Dibowitz
Applied, thank. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-06-23 Thread Phil Dibowitz
Oh, one thought... you dropped support for building consnoop, do we want to re-add that? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you

Re: [concordance-devel] [Patch] Add .dir-locals

2013-06-23 Thread Phil Dibowitz
. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind

Re: [concordance-devel] [Patch] Better Reset Status

2013-06-23 Thread Phil Dibowitz
Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those

Re: [concordance-devel] [Patch] Incorporate Debian Fixes to Man Page

2013-06-23 Thread Phil Dibowitz
On 06/16/2013 11:28 AM, Scott Talbert wrote: This patch incorporates patches to the man page that Debian has been carrying for years. God this stuff makes me super angry (when people don't send this stuff upstream). Thanks, applied. -- Phil Dibowitz p...@ipom.com

Re: [concordance-devel] [Patch] Add MIME Type

2013-06-23 Thread Phil Dibowitz
Committed. Gave additional credit to those who submitted similar patches on the tracker. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you

Re: [concordance-devel] Unable to build 1.0 on Windows

2013-06-24 Thread Phil Dibowitz
On Mon, Jun 24, 2013 at 02:31:13PM -0400, Scott Talbert wrote: On Mon, 24 Jun 2013, Phil Dibowitz wrote: Also, in some of the patches from this weekend I forgot the From: header, but since you have the first Signed-off-by header, it should be clear who it came from. I think that if I

Re: [concordance-devel] API Change for Harmony Link

2013-07-05 Thread Phil Dibowitz
other client app). I think typically in the Remote classes we've provided things like read_file() and write_file() then in libconcord we provide things like mh_configure_wifi() - and that seems like a good trend to continue. -- Phil Dibowitz p...@ipom.com Open Source

Re: [concordance-devel] [PATCH] Add a few more things to .gitignore.

2013-07-05 Thread Phil Dibowitz
is generally a ppor idea, SF's mail software ends to munge things... attaching them is probably bet. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you

Re: [concordance-devel] [PATCH] Add a few more things to .gitignore.

2013-07-05 Thread Phil Dibowitz
On 07/05/2013 05:26 PM, Phil Dibowitz wrote: On 06/25/2013 06:18 AM, Scott Talbert wrote: Signed-off-by: Scott Talbert s...@techie.net This is git-format-patch ? I'd like commit messages more than just s-o-b I can add them for this patch, because it's simple enough... but in general

Re: [concordance-devel] libhid patch

2013-07-05 Thread Phil Dibowitz
On 05/15/2013 09:01 AM, Scott Talbert wrote: On Wed, 15 May 2013, Phil Dibowitz wrote: One thing I don't quite like - I hard coded the report length to 64. We used to read this from the descriptor, but hidapi does not provide a way to get this. Not sure what to do about that. We should

Re: [concordance-devel] zip vs zzip stuff

2013-07-05 Thread Phil Dibowitz
a branch for mh-config-dumping and work there until we had the whole thing done, but it's still be multiple patches... though I prefer the previous suggestion more. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes. Use the normal byte ordering for them. Additionally, we were off by one byte when copying the the serial number data i

2013-07-23 Thread Phil Dibowitz
want to copy everything but the + * first byte, so we copy pkt[0] bytes. + */ +memcpy(data, pkt + 1, pkt[0]); return 0; Then we can nuke the calculation of 'len' here, right? And probably those commented out bits too... -- Phil Dibowitz p

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes. Use the normal byte ordering for them. Additionally, we were off by one byte when copying the the serial number data i

2013-07-24 Thread Phil Dibowitz
On 07/24/2013 08:15 AM, Scott Talbert wrote: On Wed, 24 Jul 2013, Phil Dibowitz wrote: Actually, it looks like 'len' is used elsewhere, so we can't get rid of that. I'll send a new patch with the commented lines deleted and the commit message reformatted. Huh? The function ends

Re: [concordance-devel] [PATCH] Allow for separate IR learning implementation for ZWave (HID and USBNET).

2013-07-30 Thread Phil Dibowitz
the case where there's just one extra step on one side or the other, it might be nice to keep them in one place... -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http

[concordance-devel] Some SF cleanup

2013-07-30 Thread Phil Dibowitz
I removed the old CVS repo. I then renamed the git module from src to Code, so git now falls into where CVS used to fall in the GUI, and matches a project that was setup with git from the beginning. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes.

2013-07-30 Thread Phil Dibowitz
On 07/30/2013 08:09 AM, Stephen Warren wrote: On 07/30/2013 12:25 AM, Phil Dibowitz wrote: On 07/23/2013 08:15 PM, Scott Talbert wrote: Use the normal byte ordering for them. Additionally, we were off by one byte when copying the the serial number data in UDP_Read(). Applied. Thanks

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes.

2013-07-30 Thread Phil Dibowitz
On 07/30/2013 09:16 AM, Phil Dibowitz wrote: You can edit the saved email, or simply run git commit --amend after it's been applied. If you apply a bunch of patches in a batch, you can use git rebase -i to edit commit messages further back. You likely want to do all that before you push though

Re: [concordance-devel] [PATCH] Add support for Harmony Link.

2013-08-01 Thread Phil Dibowitz
On 07/31/2013 11:23 PM, Phil Dibowitz wrote: Anyway, the more canonical examples would be WriteFlash, EraseFlash, InvalidateFlash, WriteRam, ReadRam, PrepFirmware, etc. So the more I think about this the more I realize it's not that cut and dry either. I thought hmm, but we have all sorts

Re: [concordance-devel] libhid patch

2013-08-10 Thread Phil Dibowitz
and buggy). More testing and thoughts welcome... I'd like to get this merged. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what

Re: [concordance-devel] Windows Binaries

2013-09-07 Thread Phil Dibowitz
them. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter

Re: [concordance-devel] Windows Binaries

2013-09-07 Thread Phil Dibowitz
to make it available upon request, you don't have ti distribute it *with* the binaries. (think downloading RPMs) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http

Re: [concordance-devel] Windows Binaries

2013-09-08 Thread Phil Dibowitz
On 09/07/2013 08:53 PM, Frank Walsh wrote: I'll send tomorrow. Actually, if Scott is willing to provide them for reach release, that's probably a better setup, it can be part of our pre-release check that it works on all platforms. :) -- Phil Dibowitz p...@ipom.com

Re: [concordance-devel] [PATCH] Allow for separate IR learning implementation for ZWave (HID and USBNET).

2013-09-08 Thread Phil Dibowitz
On 08/26/2013 08:26 PM, Scott Talbert wrote: On Tue, 30 Jul 2013, Scott Talbert wrote: On Mon, 29 Jul 2013, Phil Dibowitz wrote: In preparation for supporting IR learning for ZWave, change the IRLearn() function to be a subclass function for each so that IR learning can be implemented

Re: [concordance-devel] [PATCHv3] Add support for Harmony Link.

2013-09-08 Thread Phil Dibowitz
On 09/08/2013 06:16 PM, Scott Talbert wrote: On Sun, 8 Sep 2013, Phil Dibowitz wrote: +/* + * Second parameter in the read file ack message is the data length. Use + * this to determine the number of packets we should expect. + */ +uint32_t data_len = (rsp[7] 24

Re: [concordance-devel] [PATCHv3] Add support for Harmony Link.

2013-09-08 Thread Phil Dibowitz
On 09/08/2013 09:47 PM, Phil Dibowitz wrote: I'll merge it. Actually it doens't merge cleanly: Applying: Add support for Harmony Link. /home/phil/build/git/concordance/.git/rebase-apply/patch:76: trailing whitespace. #struct mh_wifi_network network[MH_MAX_WIFI_NETWORKS]; /home/phil/build

Re: [concordance-devel] libhid patch

2013-09-09 Thread Phil Dibowitz
On 09/09/2013 01:33 AM, Phil Dibowitz wrote: On 08/11/2013 06:47 AM, Scott Talbert wrote: Yeah, I think at the very least, we should do some sort of transition period. OK, this adds a new --enable-force-libusb-on-linux option which will use libusb but warn. It also removes the windows

Re: [concordance-devel] libhid patch

2013-09-09 Thread Phil Dibowitz
On 09/09/2013 04:56 PM, Scott Talbert wrote: On Mon, 9 Sep 2013, Phil Dibowitz wrote: Yeah, I think at the very least, we should do some sort of transition period. OK, this adds a new --enable-force-libusb-on-linux option which will use libusb but warn. It also removes the windows bits

Re: [concordance-devel] libhid patch

2013-09-09 Thread Phil Dibowitz
OK, here's a (hopefully) final version. There's a few autoconf/automake tweaks for MacOSX since the last version. Removed some debug code, and updated the Linux and Mac docs. Have you had any success making hidapi-raw work on Windows? -- Phil Dibowitz p...@ipom.com

Re: [concordance-devel] libhid patch

2013-09-09 Thread Phil Dibowitz
built. It actually messed me up the other day because concordance wasn't finding my remote on Windows, and I finally realized it was because it had built the libconcord.dll as the libusb version. :) Heh. That's probably a good argument to nuke that on Windows :) -- Phil Dibowitz

Re: [concordance-devel] libhid patch

2013-09-20 Thread Phil Dibowitz
a wchar_t*. Good call. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those

Re: [concordance-devel] Windows Binaries for Hosting on Sourceforge

2013-09-20 Thread Phil Dibowitz
these, and then we'll make final binaries when we release 1.1 or 2.0 or whatever we call it. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you

Re: [concordance-devel] libhid patch

2013-09-20 Thread Phil Dibowitz
|x64.ActiveCfg = Release|Win32 Which seem to be the dependent lines... Or would you prefer to handle that in a separate diff? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net

<    1   2   3   4   5   6   >