2013/6/11 ma...@apache.org
Author: markt
Date: Tue Jun 11 20:18:10 2013
New Revision: 1491940
URL: http://svn.apache.org/r1491940
Log:
Servlet 3.1 requires an ISE if getRequest() or getResponse() are called
after complete() or dispatch()
Modified:
2013/6/12 ma...@apache.org
Author: markt
Date: Wed Jun 12 18:31:30 2013
New Revision: 1492331
URL: http://svn.apache.org/r1492331
Log:
With clarification from the EG for Servlet 3.1 section 4.4 finally makes
sense. Implement the necessary restriction and add a test case.
I think that we
On 14/06/2013 03:31, Christopher Schultz wrote:
It might be nice if this were not a one-of-many decision, but if a
client could choose more than one type. A bit-mask or a list of
scan-types would be nice. I could see the same type of scanner being
used for multiple different purposes.
That is
i think all containers actually hack this part since it doesn't match the
need when you are just a little bit bigger than tomcat.
today almost all apps scans (even spring ;) so would be great to get a
nicer scanner.
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
On 14/06/2013 08:18, Romain Manni-Bucau wrote:
i think all containers actually hack this part since it doesn't match the
need when you are just a little bit bigger than tomcat.
What requirements can't be met with an SCI?
Mark
On 14/06/2013 04:05, Nick Williams wrote:
On Jun 13, 2013, at 11:23 AM, Mark Thomas wrote:
As I make my way through the Servlet 3.1 spec reviewing all the
changes to make sure they have all been implemented, I have reached
section 8.2. There are a number of related issues here.
1. Three
On 14/06/2013 07:00, Violeta Georgieva wrote:
2013/6/11 ma...@apache.org
Author: markt
Date: Tue Jun 11 20:18:10 2013
New Revision: 1491940
URL: http://svn.apache.org/r1491940
Log:
Servlet 3.1 requires an ISE if getRequest() or getResponse() are called
after complete() or dispatch()
wait SCIs stands for ServletContainerInitializer right? if so just think
all apps are not only webapps (ear typically) + the issue is really tomcat
scanning shouldn't occur if already done (or the opposite, myfaces should
reuse tomcat scanned info is here, cxf, spring, cdi container...).
*Romain
Author: markt
Date: Fri Jun 14 07:38:09 2013
New Revision: 1492973
URL: http://svn.apache.org/r1492973
Log:
Remove class loader from the scan method as class loader is accessible
from ServletContext.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
2013/6/14 Mark Thomas wrote:
On 14/06/2013 07:00, Violeta Georgieva wrote:
Is that mean that if I have AsyncListener that does some work in
onComplete() then I will not be able to use the request and response
objects?
Yes and no. You can't call getRequest() or getResponse() on the
Author: markt
Date: Fri Jun 14 07:38:41 2013
New Revision: 1492974
URL: http://svn.apache.org/r1492974
Log:
Already skipped WEB-INF/lib so no need to skip those JARs again
Modified:
tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java
Modified:
Author: markt
Date: Fri Jun 14 07:39:32 2013
New Revision: 1492975
URL: http://svn.apache.org/r1492975
Log:
Enable client of JarScanner to determine if JAR is part of a web
application or provided by the container.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Author: markt
Date: Fri Jun 14 07:40:09 2013
New Revision: 1492976
URL: http://svn.apache.org/r1492976
Log:
Add a comment on TLD JARs since no distinction is made between
TLDs provided by an application and by the container.
Modified:
Author: markt
Date: Fri Jun 14 07:40:40 2013
New Revision: 1492977
URL: http://svn.apache.org/r1492977
Log:
Shared loader should be treated as a source of application JARs
Commons and Server loaders should be treated as a source of container
JARs
Modified:
Author: markt
Date: Fri Jun 14 07:41:33 2013
New Revision: 1492978
URL: http://svn.apache.org/r1492978
Log:
Add the type of scan to the JarScanner API
This is preparation for changing how jarsToSkip are handled.
Added:
tomcat/trunk/java/org/apache/tomcat/JarScanType.java
- copied,
Author: markt
Date: Fri Jun 14 07:42:41 2013
New Revision: 1492979
URL: http://svn.apache.org/r1492979
Log:
Get JarScanFilter working with default values
Added:
tomcat/trunk/java/org/apache/tomcat/JarScanFilter.java
- copied, changed from r1492978,
Author: markt
Date: Fri Jun 14 07:43:23 2013
New Revision: 1492980
URL: http://svn.apache.org/r1492980
Log:
Add getter/setter for JarScanFilter to JarScanner
Enable JarScanFilter to be configured via a context.xml file (and
server.xml)
Modified:
Author: markt
Date: Fri Jun 14 07:43:55 2013
New Revision: 1492981
URL: http://svn.apache.org/r1492981
Log:
Add some Javadoc
Modified:
tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanFilter.java
Modified:
tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanFilter.java
Author: markt
Date: Fri Jun 14 07:44:22 2013
New Revision: 1492983
URL: http://svn.apache.org/r1492983
Log:
Add some documentation
Added:
tomcat/trunk/webapps/docs/config/jar-scan-filter.xml
Modified:
tomcat/trunk/webapps/docs/config/jar-scanner.xml
Author: markt
Date: Fri Jun 14 07:44:57 2013
New Revision: 1492984
URL: http://svn.apache.org/r1492984
Log:
Make flag that indicates if JAR is from webapp or container visible to
fragment processing code.
Modified:
tomcat/trunk/java/org/apache/catalina/deploy/WebXml.java
On 14/06/2013 08:35, Romain Manni-Bucau wrote:
wait SCIs stands for ServletContainerInitializer right? if so just think
all apps are not only webapps (ear typically)
I'd disagree. I'd say WARs are far more popular than EARs.
For EARs if there is a case for application wide scanning (not sure
that's what we do in TomEE but i don't get how a SCI (order is not
deterministic IIRC) can solve the issue.
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/
*LinkedIn:
2013/6/14 ma...@apache.org:
Author: markt
Date: Fri Jun 14 07:44:22 2013
New Revision: 1492983
URL: http://svn.apache.org/r1492983
Log:
Add some documentation
Added:
tomcat/trunk/webapps/docs/config/jar-scan-filter.xml
and also in a earlier commit
On 14/06/2013 08:54, Romain Manni-Bucau wrote:
that's what we do in TomEE but i don't get how a SCI (order is not
deterministic IIRC) can solve the issue.
You have yet to articulate exactly what the issue is.
You are correct that SCI processing order is not fully deterministic.
Container
On 14/06/2013 09:08, Konstantin Kolinko wrote:
2013/6/14 ma...@apache.org:
Author: markt
Date: Fri Jun 14 07:44:22 2013
New Revision: 1492983
URL: http://svn.apache.org/r1492983
Log:
Add some documentation
Added:
tomcat/trunk/webapps/docs/config/jar-scan-filter.xml
and also in a
Author: markt
Date: Fri Jun 14 08:12:57 2013
New Revision: 1492990
URL: http://svn.apache.org/r1492990
Log:
Fix line endings
Modified:
tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanFilter.java
(props changed)
tomcat/trunk/webapps/docs/config/jar-scan-filter.xml (props
well i think it will be handled for next spec as it was for interceptors
(but it is not that important for initializer in *applications*).
I don't get what's the issue using a scanner registry with get or create
semantic. Is it only tomcat doesn't need it by itself? If so my point is
today tomcat
On 13/06/2013 17:23, Mark Thomas wrote:
As I make my way through the Servlet 3.1 spec reviewing all the changes
to make sure they have all been implemented, I have reached section 8.2.
There are a number of related issues here.
1. Three known issues with the current SCI / fragment handling [1]
On 14/06/2013 09:14, Romain Manni-Bucau wrote:
well i think it will be handled for next spec as it was for interceptors
(but it is not that important for initializer in *applications*).
I don't get what's the issue using a scanner registry with get or create
semantic. Is it only tomcat doesn't
SCIs are too webapp linked to be usable by others, that's the point so it
needs to be proprietary ATM + SCI doesn't scan eveything (thinking to cdi
you cannot guess a bean is a cdi one before having analyzed it).
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
On 14/06/2013 09:28, Romain Manni-Bucau wrote:
SCIs are too webapp linked to be usable by others, that's the point
so it needs to be proprietary ATM
If the problem you are trying to solve is JAR scanning outside of the
Servlet container then that - frankly - isn't a Tomcat problem. Tomcat
On 14/06/2013 07:55, Violeta Georgieva wrote:
2013/6/12 ma...@apache.org
Author: markt
Date: Wed Jun 12 18:31:30 2013
New Revision: 1492331
URL: http://svn.apache.org/r1492331
Log:
With clarification from the EG for Servlet 3.1 section 4.4 finally makes
sense. Implement the necessary
can work this way, today that's not as easy as it could to replace tomat
scanning(s) (tld, classes) by tomee one.
About CDI: you basically need to pass all classes on jars with a beans.xml
to the CDI container so @HandlesType doesn't match this need really well.
*Romain Manni-Bucau*
*Twitter:
Author: markt
Date: Fri Jun 14 09:43:27 2013
New Revision: 1493011
URL: http://svn.apache.org/r1493011
Log:
Improve comments.
Rename local variable for clarity.
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
2013/6/14 ma...@apache.org:
Author: markt
Date: Fri Jun 14 09:43:27 2013
New Revision: 1493011
URL: http://svn.apache.org/r1493011
Log:
Improve comments.
Rename local variable for clarity.
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
Author: markt
Date: Fri Jun 14 09:52:53 2013
New Revision: 1493013
URL: http://svn.apache.org/r1493013
Log:
More clarity
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
Author: markt
Date: Fri Jun 14 09:53:49 2013
New Revision: 1493014
URL: http://svn.apache.org/r1493014
Log:
Further restriction as per Servlet 3.1 section 4.4
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified:
Author: markt
Date: Fri Jun 14 10:00:57 2013
New Revision: 1493015
URL: http://svn.apache.org/r1493015
Log:
As per review from voiletagg, restrictions from in Servlet 3.0, section 4.0
apply to listeners added through the pluggability API as well as via TLDs.
Modified:
tomcat/tc7.0.x/trunk/
2013/6/14 ma...@apache.org:
Author: markt
Date: Fri Jun 14 10:00:57 2013
New Revision: 1493015
URL: http://svn.apache.org/r1493015
Log:
As per review from voiletagg, restrictions from in Servlet 3.0, section 4.0
apply to listeners added through the pluggability API as well as via TLDs.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770
--- Comment #3 from Mark Thomas ma...@apache.org ---
This has been implemented in trunk for Tomcat 8.
The changes are non-trivial to back-port. I don't intend proposing a back-port
of these changes. The log4j issue can be resolved by a
https://issues.apache.org/bugzilla/show_bug.cgi?id=54083
--- Comment #1 from Mark Thomas ma...@apache.org ---
This has been implemented in trunk for Tomcat 8.
The changes are non-trivial to back-port. I don't intend proposing a back-port
of these changes.
I'll leave this open a little while in
Author: markt
Date: Fri Jun 14 13:43:56 2013
New Revision: 1493066
URL: http://svn.apache.org/r1493066
Log:
Container provided JARs should not be scanned for deployment annotations nor
should they be checked for web-fragment.xml files.
Modified:
Author: markt
Date: Fri Jun 14 13:44:43 2013
New Revision: 1493067
URL: http://svn.apache.org/r1493067
Log:
Whoops. Better comment.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL:
Author: markt
Date: Fri Jun 14 13:46:42 2013
New Revision: 1493069
URL: http://svn.apache.org/r1493069
Log:
Container provided JARs should not be scanned for deployment annotations.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified:
Author: markt
Date: Fri Jun 14 13:50:21 2013
New Revision: 1493071
URL: http://svn.apache.org/r1493071
Log:
Rename string and update text
Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Fri Jun 14 13:51:13 2013
New Revision: 1493073
URL: http://svn.apache.org/r1493073
Log:
Rename string and update text
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
Author: markt
Date: Fri Jun 14 14:14:00 2013
New Revision: 1493080
URL: http://svn.apache.org/r1493080
Log:
Always process container JARs for SCIs
Order of SCI processing for container JARs compared to web application JARs
should be the same as class loading order.
Modified:
Author: kkolinko
Date: Fri Jun 14 15:23:34 2013
New Revision: 1493113
URL: http://svn.apache.org/r1493113
Log:
Followup to r1493073: correct a typo.
Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
Modified:
Author: kkolinko
Date: Fri Jun 14 15:25:05 2013
New Revision: 1493115
URL: http://svn.apache.org/r1493115
Log:
Merged r1493113 from tomcat/trunk:
Followup to r1493073: correct a typo.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
On 14.06.2013 15:43, ma...@apache.org wrote:
Author: markt
Date: Fri Jun 14 13:43:56 2013
New Revision: 1493066
URL: http://svn.apache.org/r1493066
Log:
Container provided JARs should not be scanned for deployment annotations nor
should they be checked for web-fragment.xml files.
Sorry
On 14/06/2013 16:38, Rainer Jung wrote:
On 14.06.2013 15:43, ma...@apache.org wrote:
Author: markt
Date: Fri Jun 14 13:43:56 2013
New Revision: 1493066
URL: http://svn.apache.org/r1493066
Log:
Container provided JARs should not be scanned for deployment annotations nor
should they be checked
Mark,
On 6/14/13 3:16 AM, Mark Thomas wrote:
On 14/06/2013 03:31, Christopher Schultz wrote:
It might be nice if this were not a one-of-many decision, but if a
client could choose more than one type. A bit-mask or a list of
scan-types would be nice. I could see the same type of scanner
Romain,
On 6/14/13 5:38 AM, Romain Manni-Bucau wrote:
can work this way, today that's not as easy as it could to replace tomat
scanning(s) (tld, classes) by tomee one.
About CDI: you basically need to pass all classes on jars with a beans.xml
to the CDI container so @HandlesType doesn't
Cdi handle interfaces too which are not Object.
About throwing away classloader that's what we do in tomee.
Le 14 juin 2013 18:09, Christopher Schultz ch...@christopherschultz.net
a écrit :
Romain,
On 6/14/13 5:38 AM, Romain Manni-Bucau wrote:
can work this way, today that's not as easy as
Mark,
On 6/14/13 11:54 AM, Mark Thomas wrote:
On 14/06/2013 16:38, Rainer Jung wrote:
On 14.06.2013 15:43, ma...@apache.org wrote:
Author: markt
Date: Fri Jun 14 13:43:56 2013
New Revision: 1493066
URL: http://svn.apache.org/r1493066
Log:
Container provided JARs should not be scanned for
Romain,
On 6/14/13 12:13 PM, Romain Manni-Bucau wrote:
Cdi handle interfaces too which are not Object.
There are interfaces which are do not extend Object?
There is essentially a base interface that declares every method in
java.lang.Object. It's simply not possible to have an instance of an
On 14/06/2013 16:57, Christopher Schultz wrote:
Mark,
On 6/14/13 3:16 AM, Mark Thomas wrote:
On 14/06/2013 03:31, Christopher Schultz wrote:
It might be nice if this were not a one-of-many decision, but if a
client could choose more than one type. A bit-mask or a list of
scan-types would be
On 14/06/2013 17:15, Christopher Schultz wrote:
I was actually hoping that certain JDBC drivers would start packaging a
listener that could do things like stop driver-launched threads, etc.
that the user doesn't really know have been started. Will this then
always be a requirement of the webapp
Mark,
On 6/14/13 12:21 PM, Mark Thomas wrote:
On 14/06/2013 16:57, Christopher Schultz wrote:
Mark,
On 6/14/13 3:16 AM, Mark Thomas wrote:
On 14/06/2013 03:31, Christopher Schultz wrote:
It might be nice if this were not a one-of-many decision, but if a
client could choose more than one
Mark,
On 6/14/13 12:22 PM, Mark Thomas wrote:
On 14/06/2013 17:15, Christopher Schultz wrote:
I was actually hoping that certain JDBC drivers would start packaging a
listener that could do things like stop driver-launched threads, etc.
that the user doesn't really know have been started. Will
On 14 June 2013 17:35, Christopher Schultz ch...@christopherschultz.net wrote:
Mark,
On 6/14/13 12:21 PM, Mark Thomas wrote:
On 14/06/2013 16:57, Christopher Schultz wrote:
Mark,
On 6/14/13 3:16 AM, Mark Thomas wrote:
On 14/06/2013 03:31, Christopher Schultz wrote:
It might be nice if
FYI xbean has runtime constraints bcel skips (valid read and loaded info
are consistent)
Le 14 juin 2013 18:56, sebb seb...@gmail.com a écrit :
On 14 June 2013 17:35, Christopher Schultz ch...@christopherschultz.net
wrote:
Mark,
On 6/14/13 12:21 PM, Mark Thomas wrote:
On 14/06/2013
Sebb,
On 6/14/13 12:55 PM, sebb wrote:
On 14 June 2013 17:35, Christopher Schultz ch...@christopherschultz.net
wrote:
Mark,
On 6/14/13 12:21 PM, Mark Thomas wrote:
On 14/06/2013 16:57, Christopher Schultz wrote:
Mark,
On 6/14/13 3:16 AM, Mark Thomas wrote:
On 14/06/2013 03:31,
On 14.06.2013 18:36, Christopher Schultz wrote:
Mark,
On 6/14/13 12:22 PM, Mark Thomas wrote:
On 14/06/2013 17:15, Christopher Schultz wrote:
I was actually hoping that certain JDBC drivers would start packaging a
listener that could do things like stop driver-launched threads, etc.
that
Geronimo's xbean-finder also supplies this functionality using asm.
david jencks
On Jun 14, 2013, at 9:55 AM, sebb seb...@gmail.com wrote:
On 14 June 2013 17:35, Christopher Schultz ch...@christopherschultz.net
wrote:
Mark,
On 6/14/13 12:21 PM, Mark Thomas wrote:
On 14/06/2013 16:57,
Author: markt
Date: Fri Jun 14 18:32:18 2013
New Revision: 1493194
URL: http://svn.apache.org/r1493194
Log:
Special handling for isUserInRole(*)
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL:
On 14/06/2013 18:53, Christopher Schultz wrote:
BCEL reads class files as files.
http://commons.apache.org/proper/commons-bcel/
No, I get that, but the scanner ultimately has to use a ClassLoader to
load Class objects so they can be passed-off to the SCIs. Which
ClassLoader does that?
The
Author: markt
Date: Fri Jun 14 18:43:13 2013
New Revision: 1493197
URL: http://svn.apache.org/r1493197
Log:
Special handling for isUserInRole(**)
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
Author: markt
Date: Fri Jun 14 20:14:05 2013
New Revision: 1493231
URL: http://svn.apache.org/r1493231
Log:
Fix typos
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java
Modified:
69 matches
Mail list logo
