[PATCH] (7) Miscellaneous cleanup

2021-11-15 Thread Dominik Vogt
in the man page and remove the MWM references. Remove "features" that are not noteworthy nowadays. 0007: Remove the "MWM COMPATIBILITY" section. Nobody cares anymore. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From e1ba8a6c1b3d77c501330acc53e98c8ffbbddf62 Mon Sep 17 00:00:0

[PATCH] Alt key during move and resize enables paging.

2021-11-15 Thread Dominik Vogt
: Style * EdgeMoveDelay -1, EdgeResizeDelay -1 Ciao Dominik ^_^ ^_^ -- Dominik Vogt From bd8ead5aa462fd68acee06f89725e12b4e5eb79c Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 23:56:12 +0100 Subject: [PATCH 1/4] Pressing Alt during "Move" enables immediate paging. ---

[PATCH] (2) Remove Dmalloc and Efence support.

2021-11-14 Thread Dominik Vogt
0001: Remove Efence and Dmalloc support. 0002: Remove trailing whitespace. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 0d9780ca99675083470398857d149e3d1f05f84e Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Mon, 15 Nov 2021 02:03:44 +0100 Subject: [PATCH 1/2] Remove Efence and Dmalloc

Re: Removind dmalloc and efence support?

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:49:58AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:42:33AM +0100, Dominik Vogt wrote: > > Has anybody really used them in the last fifteen years? Since > > valgrind has become pretty stable and good I never saw a need for > > dmall

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:45:18AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:36:15AM +0100, Dominik Vogt wrote: > > While we're at it, much of the markup could be removed. The > > manpage is partially unreadable because too many words have markup > > (especially

Removind dmalloc and efence support?

2021-11-14 Thread Dominik Vogt
Has anybody really used them in the last fifteen years? Since valgrind has become pretty stable and good I never saw a need for dmalloc or efence any more. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: Plans for the NEWS file?

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:30:34AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:18:49AM +0100, Dominik Vogt wrote: > > Is the NEWS file going to be used for 3.x releases too? I always > > found it easier to add new entries when patches are written > > instead

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:24:42AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:16:06AM +0100, Dominik Vogt wrote: > > Of course. What is the maximum line length that was used to > > format the .adoc files? (Can we re-add some formatting > > instructions in

[PATCH] (3) Miscellaneous updates

2021-11-14 Thread Dominik Vogt
0001: Improve Snap... docuemntation. 0002: Improve EdgeMoveDelay documentation. 0003: Remove superfluous "#if 1". Ciao Dominik ^_^ ^_^ -- Dominik Vogt From bda6a6a423ac05b68e65fc850afba9de57c6e46c Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 23:30:49 +01

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Sun, Nov 14, 2021 at 11:57:27PM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 12:31:28AM +0100, Dominik Vogt wrote: > > On Mon, Nov 15, 2021 at 12:19:59AM +0100, Dominik Vogt wrote: > > > What do you think about the attached patch? Pressing "Alt" during >

Plans for the NEWS file?

2021-11-14 Thread Dominik Vogt
uot; phase at the moment? Ciao Dominik ^_^ ^_^ -- Dominik Vogt

[PATCH] Reject out of range windows for Move and Resize commands.

2021-11-14 Thread Dominik Vogt
Fixes programs going crazy when you accidentally say something like all (mplayer) resize 1920 1200 instead of all (mplayer) resize 1920p 1200p (Generates an error message without doing anything else.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt From c7e032441e57cb59b4472e6396e64da45b7628c6

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:19:59AM +0100, Dominik Vogt wrote: > What do you think about the attached patch? Pressing "Alt" during > an interactive move already disables snapping. It's easy to make > it enable paging without any delay too. I like it. > > You can say &g

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Sun, Nov 14, 2021 at 04:51:26PM +, Thomas Adam wrote: > On Sun, Nov 14, 2021 at 04:50:23PM +0100, Dominik Vogt wrote: > > Current situation for me: At least 90% of all paging situations > > are accidents. > > Yeah, and it gets even worse if you

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Sun, Nov 14, 2021 at 03:35:12PM +, Thomas Adam wrote: > On Sun, Nov 14, 2021 at 01:55:32PM +0100, Dominik Vogt wrote: > > 1) Because the pointer is at the top of the screen, it's > > immediately in the one pixel high panning window, so fvwm waits > > the configured 500

Re: Snapping issue

2021-11-14 Thread Dominik Vogt
, Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Paging issue

2021-11-14 Thread Dominik Vogt
has moved, the window ist still completely on page 0 1. Not a single pixel is visible. Overall, the implementation of paging is annoying, and Ive no idea how to fix it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Snapping issue

2021-11-14 Thread Dominik Vogt
dge of the screen because it prefers to snap to the button bar instead. Try it out yourself. I just don't know how to "fix" it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

[PATCH] (7) Remove ifdefs

2021-11-14 Thread Dominik Vogt
#1, 2, 3 and 5 remove code that hasn't been used in ages. #4 removes an ifdef that commented out code that shouldn't be. #6 makes a very old code switch permanent. #7 general ifdef and debug output cleanup. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 6d65cc40b6371f4d0a7a2adf5254e2e329ded7ab

[PATCH] 1/3 Fix and document "bugopts debugrandr".

2021-11-14 Thread Dominik Vogt
The patch makes the bogus "bugopts debugrandr" option actually do something. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 415a98341f4f33495d58c4b74718a25a3a83eff8 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 10:54:20 +0100 Subject: [PATCH 1/3] Fix and documen

Re: [PATCH] 3/3 Correct typo.

2021-11-14 Thread Dominik Vogt
Typo in error message. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 2d6ceb2c0650a7b0e30a3be7a04363e59b83370e Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 10:55:53 +0100 Subject: [PATCH 3/3] Correct typo. --- fvwm/conditional.c | 2 +- 1 file changed, 1 insertion(+), 1

Re [PATCH] 4/3 Enable EWMH debug messages with "bugopts debugrandr"

2021-11-14 Thread Dominik Vogt
Put EWMH_GetWorkAreaIntersection debug messages in the "debugrandr" category. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 367de6c621cf768e13d3edb596c91176e2f62265 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 11:02:48 +0100 Subject: [PATCH 4/4] Enable EWMH debu

Re: [PATCH] 2/3 Sanitize screen related code indentation.

2021-11-14 Thread Dominik Vogt
(No indentation with spaces.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt From e04bcd721ea1ebbbf64eec7463cc4dadde7fb88c Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 10:55:32 +0100 Subject: [PATCH 2/3] Sanitize screen related code indentation. --- libs/FScreen.c | 85

v3 changes

2021-11-13 Thread Dominik Vogt
with plain "-Wall -Werror". Good. * INSTALL file is gone. Bad. Required by GNU standards. * Third party (Go) sources in distribution = license trouble. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [fvwmorg/fvwm3] f51066: read: remove custom fgets logic and use fparseln()

2019-05-16 Thread Dominik Vogt
restriction is now rather limiting. Note that we've never really removed the limit because longer lines break the module interface. I.e., if a long line is transferred over the module pipe, strange things can happen because of mutilated lines. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: fvwm 2.6.x title vs icon title bug

2017-03-01 Thread Dominik Vogt
fvwm-2.6.7.o/fvwm/style.h > +++ fvwm-2.6.7/fvwm/style.h > @@ -5,6 +5,7 @@ > > /* The default title in case the user doesn't supply one. */ > #define DEFAULT_TITLE_FORMAT "%n" > +#define DEFAULT_ICON_TITLE_FORMAT "%i" > > /* access to the special flags of a style */ > /* call these with a pointer to a style_flags struct */ > > -- > HTH, lynx. > 494 lives. > > > Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: CVS domivogt: * Write fvwm in lower case everywhere

2007-08-08 Thread Dominik Vogt
Log message: * Write fvwm in lower case everywhere I disagree with this policy. (sigh, FVWM has been popping up all over the place since the last time I cahanged this).. That's because lower case acronyms are counter-intuitive uncommon. My opinion is that * Acronyms are

Re: PictureImageLoader stuff broken when using --without-xpm-library

2007-07-16 Thread Dominik Vogt
-20070716/ChangeLog 2007-07-16 12:34:22.0 +0200 @@ -1,5 +1,17 @@ 2007-07-16 Dominik Vogt dominik(dot)vogt(at)gmx(dot)de + * libs/Fxpm.h: + fixed compile error + + * libs/PictureImageLoader.c: + cleanup + (PImageLoadCursorFromFile): + fixed compilation without xpm library + (PImageLoadPng

Re: Condition Visible does not seem to work when xcompmgr is running.

2007-07-02 Thread Dominik Vogt
Dominik ^_^ ^_^ -- Dominik Vogt, dominik.vogt (at) gmx.de signature.asc Description: Digital signature

Re: CVS renato: * Created function module_add_to_fdsets from events.c and module_interface.c

2007-01-02 Thread Dominik Vogt
In the tests I'm calling the function GetFdWidth() twice for every module, which may incur in a bit overhead.. There's a global var called fd_width. I don't know if I should use the it instead, but supose it should be removed.. I've also considered the use of a static global var to improve

Re: CVS domivogt: * Fixed the TitleWarp menu style.

2006-10-25 Thread Dominik Vogt
? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Transparency / Font Shadow weirdness

2006-10-02 Thread Dominik Vogt
.. http://img441.imageshack.us/img441/7140/fvwmfontcp3.png This doesn't seem to happen with all wallpapers, It happens with this particular one. http://img426.imageshack.us/img426/706/altabadia2lf1.png (around 1.3MB) I'm using fvwm-2.5.16 Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL

fvwm-2.5.18 has been released

2006-09-11 Thread Dominik Vogt
Tarballs and ANNOUNCE file are in the usual place. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: some 64bit cleanup on CVS head (XGetWindowProperty())

2006-09-01 Thread Dominik Vogt
tried the patch, but it seemed that the changes were already there.. That's because I already committed the fix. There should have been a CVS mail about it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: MapWindow directly after UnmapWindow

2006-08-30 Thread Dominik Vogt
^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: MapWindow directly after UnmapWindow

2006-08-30 Thread Dominik Vogt
On Tue, Aug 29, 2006 at 10:18:30PM +0200, Viktor Griph wrote: On Tue, 29 Aug 2006, Viktor Griph wrote: On Tue, 29 Aug 2006, Dominik Vogt wrote: On Mon, Aug 28, 2006 at 08:07:31PM +0200, Viktor Griph wrote: On Mon, 28 Aug 2006, Andreas Ehliar wrote: I have a problem with fpga_editor

Re: some 64bit cleanup on CVS head (XGetWindowProperty())

2006-08-29 Thread Dominik Vogt
and the main window are correct. Okay, I've applied the patch. Can you please provide ChangeLog entries for it? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: MapWindow directly after UnmapWindow

2006-08-29 Thread Dominik Vogt
be any downside with solution 3, in which case solution 2 is the one to take. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Handling of MapRequests

2006-08-29 Thread Dominik Vogt
uncunditionally for all MapRequests? Or should the unmap nofify handler check for pending map requests of the window before destroying it in the first place? No, see my reply in that other thread. Can you please try to explain your question again? Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: CVS griph: * use ewmh allowed actions to track window movability

2006-08-10 Thread Dominik Vogt
On Thu, Aug 10, 2006 at 12:58:06PM +0200, Viktor Griph wrote: On Thu, 10 Aug 2006, Dominik Vogt wrote: On Thu, Aug 10, 2006 at 04:24:48AM -0500, fvwm-workers wrote: CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: griph 06/08/10 04:24:48 Modified files

Re: Tracking flag changes from modules

2006-08-09 Thread Dominik Vogt
optimal since the action is clearly triggered by the user, not an application. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * don't map picture icon windows on move

2006-08-09 Thread Dominik Vogt
. I've committed a fix. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * if 0 (with comments) questionable code doing double work

2006-08-09 Thread Dominik Vogt
be removed. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FvwmIconMan: debug code cleanup

2006-08-08 Thread Dominik Vogt
^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: icon movement tracking

2006-08-08 Thread Dominik Vogt
, moving an icon by one or more full pages should move the underlying window geometries (normal and maximized (if applicable) by the same distance. This is a bit tricky, but if you make an initial patch I would take a look at the issue. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED

Re: Tracking flag changes from modules

2006-08-08 Thread Dominik Vogt
On Tue, Aug 08, 2006 at 04:18:41PM +0100, seventh guardian wrote: On 8/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: As a way to provide backward compatibility and minimizing the effects of the above VISIBLE changes there could be provided a command that the modules could use to request

Re: Tracking flag changes from modules

2006-08-08 Thread Dominik Vogt
On Tue, Aug 08, 2006 at 04:31:00PM +0100, Thomas Adam wrote: On Tue, 8 Aug 2006 16:18:41 +0100 seventh guardian [EMAIL PROTECTED] wrote: On 8/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: As a way to provide backward compatibility and minimizing the effects of the above VISIBLE

Re: FvwmIconMan: debug code cleanup

2006-08-08 Thread Dominik Vogt
On Tue, Aug 08, 2006 at 07:28:32PM +0100, seventh guardian wrote: On 8/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 8/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 08, 2006 at 12:16:44AM +0400, Serge (gentoosiast) Koksharov wrote: Hello, Here some documentation

Re: Tracking flag changes from modules

2006-08-07 Thread Dominik Vogt
On Mon, Aug 07, 2006 at 07:26:40PM +0200, Viktor Griph wrote: On Mon, 7 Aug 2006, Dominik Vogt wrote: Is there any way that the module interface allows keeping track of changes to the window flags of a window? Currently FvwmPager allows moving of FixedPosition mini-windows, but the main

Re: FvwmIconMan: a few trivial fixes

2006-08-06 Thread Dominik Vogt
an argument to Shape option is omitted. Done. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FvwmForm: WM_DELETE_WINDOW support

2006-08-06 Thread Dominik Vogt
title. Committed. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Manpage fix for 2.5.17: Wait command.

2006-07-31 Thread Dominik Vogt
On Sat, Jul 29, 2006 at 10:21:35PM +0100, Thomas Adam wrote: On Sat, 29 Jul 2006 10:50:21 +0200 Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 28, 2006 at 11:30:19AM +0100, Thomas Adam wrote: Scott -- On Fri, 28 Jul 2006 15:27:22 +1000 Scott Smedley [EMAIL PROTECTED] wrote

Re: Patching FvwmButtons to use Balloons (tooltips).

2006-07-31 Thread Dominik Vogt
of this. I've not looked too deeply into it yet, and wanted to seek approval/recommendations, etc., before I went ahead to try and do this. We're not using Ftips yet. Feel free to make changes. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital

Re: Manpage fix for 2.5.17: Wait command.

2006-07-29 Thread Dominik Vogt
command with GotoDesk since this is now the preferred command to use. Ok. ThisWindow (thomas_adam) Destroy ThisWindow (thomas_adam) Wait godo :) Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Title font color broken

2006-07-29 Thread Dominik Vogt
On Tue, Jun 06, 2006 at 03:29:39PM -0400, Dan Espen wrote: Serge (gentoosiast) Koksharov [EMAIL PROTECTED] writes: On Sun, Jun 04, 2006 at 11:15:29AM +0200, Dominik Vogt wrote: Unfortunately I never got any feedback on this from the person who reported it first. The problem

Re: Where did the MenuStyle ActiveBack go?

2006-07-25 Thread Dominik Vogt
I found this unusual thing in the manual. There is a reference to ActiveBack/ActiveBackOff all over the place, but aparently the style doesn't exist any more. It is not documented at all, nor is mentioned in (both) the ChangeLogs.. Not even in any part of the source code. Is there a

Re: CVS scott fvwm-web: Updated on-line man pages for 2.5.17.

2006-07-21 Thread Dominik Vogt
mention it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: MenuStyle options - negate or not to negate?

2006-07-21 Thread Dominik Vogt
Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

fvwm-2.5.17 has been released and uploaded

2006-07-19 Thread Dominik Vogt
Tarballs and ANNOUNCE file are in the usual place. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Adding the possibility of not compiling deprecated code ?

2006-07-17 Thread Dominik Vogt
to the user. There have aleady been attempts at writing small parsers such as fvwm-convert-2.{4,6} -- although they're not briliant they do a good enough job. I don't know of many people that use them though. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description

Re: bug: 'CopyMenuStyle' command don't copies 'TitleColorset'

2006-07-17 Thread Dominik Vogt
have a good time everyone Thanks. I'll apply that patch. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Flags - is negation prefered?

2006-07-17 Thread Dominik Vogt
. the (stylename)Off code should be maintained for compatibility's sake, but marked as deprecated. The ! negation style is preferred. I coded it for exactly the reasons you describe. There are so many different typed of on/off syntax. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED

Re: bugfix with clearing 'NoIcon' style

2006-07-16 Thread Dominik Vogt
On Sat, Jul 15, 2006 at 03:55:17AM +0400, Serge (gentoosiast) Koksharov wrote: On Fri, Jul 14, 2006 at 12:28:45AM +0200, Dominik Vogt wrote: Um, if the manpage is not clear enough, it should be reworded. The NoIcon style is *of course* overridden by specifying an icon, Oh, I missed

Re: CVS griph: * add variable filters

2006-07-16 Thread Dominik Vogt
! Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * add variable filters

2006-07-16 Thread Dominik Vogt
On Sun, Jul 16, 2006 at 02:42:03PM +0200, Viktor Griph wrote: On Sun, 16 Jul 2006, Dominik Vogt wrote: Please take this as a base for discussion, *not* as instructions to change the code now! So, should the current patch to expand.c and the manpage be reverted until the system has been

Re: FVWM crashes with $[0]

2006-07-14 Thread Dominik Vogt
or may not increase the return code by one, so if rc = scanf(..., %u-%n, ...); returns one, this can mean is parsed just the integer and stopped, or it parsed the integer, found a '-' and assigned the %n too. Fixed. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc

Re: FVWM crashes with $[0]

2006-07-14 Thread Dominik Vogt
On Fri, Jul 14, 2006 at 10:18:28AM +0200, Viktor Griph wrote: On Fri, 14 Jul 2006, Dominik Vogt wrote: On Fri, Jul 14, 2006 at 09:07:21AM +0200, Viktor Griph wrote: On Fri, 14 Jul 2006, Scott Smedley wrote: I think there is a bug in FVWM's parameter expansion. FVWM crashes with a simple

Re: CVS domivogt: * Removed ifdefs from fifos.c.

2006-07-13 Thread Dominik Vogt
^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
in an earlier message, PeekToken never returns an empty string. Calling PeekToken(, ...) returns a NULL pointer which the code accessed later. I've fixed all three. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS domivogt: * Removed ifdefs from fifos.c.

2006-07-13 Thread Dominik Vogt
On Thu, Jul 13, 2006 at 11:01:13AM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: Is it really neccessary to defene everything with FVWM_ as a prefix? If it's not already defined, why not define it using the expected name? I use the fvwm prefix to document that we

Re: Removing gnome support from FvwmGtk

2006-07-13 Thread Dominik Vogt
^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
On Thu, Jul 13, 2006 at 02:55:24PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: On Thu, Jul 13, 2006 at 09:25:09AM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Scott Smedley wrote: Hi all, I think there is a bug in FVWM's parameter expansion. FVWM crashes

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
On Thu, Jul 13, 2006 at 04:10:53PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: [snip] Not true. With 'is_single_arg' true 'upper' will always be -1, so no other parse-function will be called on the string. Then, why do you not write if (is_single_arg

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
Sorry, I've just removed your latest patch. The only difference between the old and new param style is now that $* does not dequote arguments while $[*] does. I'm not sure that this is good. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
On Thu, Jul 13, 2006 at 05:00:27PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: On Thu, Jul 13, 2006 at 02:55:24PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: On Thu, Jul 13, 2006 at 09:25:09AM +0200

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
On Thu, Jul 13, 2006 at 05:07:17PM +0200, Dominik Vogt wrote: On Thu, Jul 13, 2006 at 04:10:53PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: [snip] Not true. With 'is_single_arg' true 'upper' will always be -1, so no other parse-function will be called on the string

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
On Thu, Jul 13, 2006 at 06:39:40PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: On Thu, Jul 13, 2006 at 04:10:53PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: [snip] Hm, now that I think about it, the new functionality deviates from the way

Re: FVWM crashes with $[0]

2006-07-13 Thread Dominik Vogt
On Thu, Jul 13, 2006 at 06:12:05PM +0200, Viktor Griph wrote: On Thu, 13 Jul 2006, Dominik Vogt wrote: I don't have much time now, but two random test results: Echo $[-0] should print the first argument but prints $[-0] This construct is not in the manpage (and thus never implemented

Re: CVS griph: fix tempfile vulnerabilities in FvwmCommand (bug

2006-07-12 Thread Dominik Vogt
On Wed, Jul 12, 2006 at 01:28:45AM +0200, Viktor Griph wrote: On Tue, 11 Jul 2006, Dominik Vogt wrote: On Tue, Jul 11, 2006 at 10:16:09AM -0500, fvwm-workers wrote: CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: griph 06/07/11 10:16:09 Modified files

Re: CVS griph: fix tempfile vulnerabilities in FvwmCommand (bug

2006-07-12 Thread Dominik Vogt
On Wed, Jul 12, 2006 at 09:50:01AM +0200, Dominik Vogt wrote: On Wed, Jul 12, 2006 at 01:28:45AM +0200, Viktor Griph wrote: Good, but I don't want new ifdefs in the code. Instead, please add this to the end of the AH_VERBATIM macro _ZEND_EXPLICIT_DEFINITIONS in configure.ac, beginning at line

KillModule fix

2006-07-11 Thread Dominik Vogt
The attached patch fixes the broken KillModule command. Can someone please apply it? ChangeLog: 2006-07-11 Dominik Vogt dominik(dot)vogt(at)gmx(dot)de * fvwm/module_interface.c (KillModule, ClosePipes): fixed KillModule Ciao Dominik ^_^ ^_^ -- Echte DSL-Flatrate

Re: CVS griph: fix tempfile vulnerabilities in FvwmCommand (bug #2791).

2006-07-11 Thread Dominik Vogt
: FvwmCommand.1.in FvwmCommand.c FvwmCommandS.c fifos.c Log message: fix tempfile vulnerabilities in FvwmCommand (bug #2791). Can you explain what you actually did, please? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital

Re: using lstat

2006-07-11 Thread Dominik Vogt
^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS domivogt: * Fixed parsing of Periodic option.

2006-07-11 Thread Dominik Vogt
and the calling function has to free() it. If possible, use PeekToken because it's faster and does not risk creating memory leaks. Note that both functions never return an empty token, i.e. a string that consists just of the terminating zero. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL

Re: CVS renato: Removed the warning about the obsolete option -blackout.

2006-07-09 Thread Dominik Vogt
On Sun, Jul 09, 2006 at 01:00:08AM +0100, seventh guardian wrote: On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't

Re: CVS renato: Removed the warning about the obsolete option -blackout.

2006-07-08 Thread Dominik Vogt
the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital

Re: Separating compat code from libfvwm

2006-07-08 Thread Dominik Vogt
that. Whats the difference between having them in libfvwm.a or a different lib? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS renato: Removed the warning about the obsolete option -blackout.

2006-07-08 Thread Dominik Vogt
On Sat, Jul 08, 2006 at 11:48:43PM +0100, seventh guardian wrote: On 7/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes

Re: debug.c still useful?

2006-07-07 Thread Dominik Vogt
. It's a big decision to remove a whole file, so I need a second opinion.. Is the file still useful or may I remove it? Well, usefull or not - if we don't use it we don't need it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Libtool ltdl on fvwm

2006-07-07 Thread Dominik Vogt
). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: debug vs fvwm_debug_msgs

2006-07-06 Thread Dominik Vogt
and stuff that is not needed anymore. The only useful module debug code I am aware of is in the FvwmAuto module. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: debug code cleanup patch #1

2006-07-06 Thread Dominik Vogt
^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: debug vs fvwm_debug_msgs

2006-07-06 Thread Dominik Vogt
On Thu, Jul 06, 2006 at 04:22:28PM +0100, seventh guardian wrote: On 7/6/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Wed, Jul 05, 2006 at 02:35:10PM +0100, seventh guardian wrote: On 7/5/06, seventh guardian [EMAIL PROTECTED] wrote: Hi. I have found FVWM_DEBUG_MSGS and DEBUG ifdef's

Re: debug code cleanup patch #1

2006-07-06 Thread Dominik Vogt
On Thu, Jul 06, 2006 at 08:23:50PM +0100, seventh guardian wrote: On 7/6/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Thu, Jul 06, 2006 at 05:20:14PM +0100, seventh guardian wrote: Hi. This is a debug code cleanup patch: It removes most of the FvwmPager debug code (very old), also

Re: Periodic command

2006-07-05 Thread Dominik Vogt
and describe). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: renamed conflicting getline function to get_line (bug #3772)

2006-07-05 Thread Dominik Vogt
getline function to get_line (bug #3772) Thanks, but please add a NEWS entry too. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Grabbing and complex functions

2006-06-29 Thread Dominik Vogt
Goikhman wrote: On 29 Jun 2006 00:44:22 +0200, Dominik Vogt wrote: We would have to exclude at least: * Anything that can generate dynamic functions because it is impossible to decide about whether a grab is needed (Read, PipeRead, expanding variables or environment variables

Re: Grabbing and complex functions

2006-06-28 Thread Dominik Vogt
are I - immediately executed. How do others feel about this option? If there are objections I will happily remove it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: ModuleListenOnly command

2006-06-28 Thread Dominik Vogt
period of time has passed. Well, with zsh there is zselect that can trigger on both events at the same time (works like select()), but other than that I'd have to make something up with reading the fvwm pipe in a subshell (because it blocks the shell). Ciao Dominik ^_^ ^_^ -- Dominik Vogt

ModuleListenOnly command

2006-06-24 Thread Dominik Vogt
15 -d 3 -c clock -t topproc *FvwmButtons(11x1+30+0, Colorset 8, Id clock, Title , Action nop) *FvwmButtons(12x1+29+4, Colorset 8, Id topproc, Title , Action nop) (zsh script attached). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] #!/usr/bin/zsh emulate zsh setopt HUP zmodload

<    1   2   3   4   5   6   7   8   9   10   >