On Sun, Nov 04, 2018 at 05:36:45AM +0000, Ken Moffat via blfs-dev wrote:
> On Sun, Nov 04, 2018 at 02:18:13AM +0100, dueffert--- via blfs-dev wrote:
> > Worked for the moment, but wasn't really a solution. So I waited for
> > firefox-63.0.1, but that did not change anything. Then I digged for the
> > source of the problem - and it is rather easy:
> >
> AFAICS, Bruce's scripts think that doesn't exist, so I'm ignoring it
> ;-) Seriously, I'm "up to my arse in alligators" [1] in the perl
> modules, so -ENOCYCLES.
>
Getting ready for a fresh build (my first with ICU-63) -
>
> > The relevant difference between icu-62.1 and icu-63.1 is that the latter
> > started to have "checkImpl" in their public headers. Which conflicts with
> > some completely different "checkImpl" in Firefox.
> >
> > The usage of "checkImpl" in Firefox is pretty limited and I can easiely get
> > Firefox-63 to build and work fine with system icu-63.1 by applying:
> > sed -e 's/checkImpl/checkFFImpl/g' -i js/src/vm/JSContext*.h
> >
> > I have no clue what upstream thinks about that, but my gut feeling is that
> > "checkImpl" sounds way too general to be exported like that. So I suppose
> > it's icu which would need some fixing, but as I can't guess their intention
> > (or its consequences), it's way easier for me to just patch Firefox to
> > build.
> >
> > I'd appreciate if someone more confident would report that at either
> > upstream project...
> >
> > Uwe
>
You did not mention that people using old ICU (e.g. 60) also had the
problem. Looking at firefox, it claims to include 59.1, but
presumably something has been altered in the local version.
Anyway, with 63.0.1 on BLFS-8.2 (ICU 60) that sed works. It also
works on this-week's 64 beta on an 8.3 / 62 system where it is not
needed, so I think we should just pick it up.
I'm now getting ready to build a fresh system (my first with ICU
63). Will see how it goes, there are other changes which might
break it.
ĸen
--
Is it about a bicycle ?
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page