github-code-scanning[bot] commented on code in PR #15133:
URL: https://github.com/apache/druid/pull/15133#discussion_r1355664538
##########
extensions-contrib/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/KubernetesTaskRunnerTest.java:
##########
@@ -269,11 +270,89 @@
replayAll();
ListenableFuture<TaskStatus> future = runner.run(task);
+ TaskStatus taskStatus = future.get();
+ Assert.assertEquals(TaskState.FAILED, taskStatus.getStatusCode());
+ Assert.assertEquals("Could not start task execution",
taskStatus.getErrorMsg());
+ verifyAll();
+ }
- Exception e = Assert.assertThrows(ExecutionException.class, future::get);
- Assert.assertTrue(e.getCause() instanceof RuntimeException);
+ @Test
+ public void test_run_updateStatus() throws ExecutionException,
InterruptedException
+ {
+ KubernetesTaskRunner runner = new KubernetesTaskRunner(
+ taskAdapter,
+ config,
+ peonClient,
+ httpClient,
+ new TestPeonLifecycleFactory(kubernetesPeonLifecycle),
+ emitter
+ );
+ KubernetesWorkItem workItem = new KubernetesWorkItem(task);
+ runner.tasks.put(task.getId(), workItem);
+ TaskStatus completeTaskStatus = TaskStatus.success(task.getId());
+
+ replayAll();
+ runner.updateStatus(task, completeTaskStatus);
verifyAll();
+
+ assertTrue(workItem.getResult().isDone());
+ assertEquals(completeTaskStatus, workItem.getResult().get());
+ }
+
+ @Test
+ public void test_run_updateStatus_running()
+ {
+ KubernetesTaskRunner runner = new KubernetesTaskRunner(
+ taskAdapter,
+ config,
+ peonClient,
+ httpClient,
+ new TestPeonLifecycleFactory(kubernetesPeonLifecycle),
+ emitter
+ );
+ KubernetesWorkItem workItem = new KubernetesWorkItem(task);
+ runner.tasks.put(task.getId(), workItem);
+ TaskStatus runningTaskStatus = TaskStatus.running(task.getId());
+
+ replayAll();
+ runner.updateStatus(task, runningTaskStatus);
+ verifyAll();
+
+ assertFalse(workItem.getResult().isDone());
+ }
+
+ @Test
+ public void test_registerListener_runningTask()
+ {
+ KubernetesTaskRunner runner = new KubernetesTaskRunner(
+ taskAdapter,
+ config,
+ peonClient,
+ httpClient,
+ new TestPeonLifecycleFactory(kubernetesPeonLifecycle),
+ emitter
+ );
+
+ KubernetesPeonLifecycle kubernetesPeonLifecycle =
EasyMock.mock(KubernetesPeonLifecycle.class);
Review Comment:
## Possible confusion of local and field
Confusing name: method [test_registerListener_runningTask](1) also refers to
field [kubernetesPeonLifecycle](2) (without qualifying it with 'this').
[Show more
details](https://github.com/apache/druid/security/code-scanning/5887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
