YongGang commented on code in PR #15133:
URL: https://github.com/apache/druid/pull/15133#discussion_r1361143507
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -172,10 +176,12 @@ private TaskStatus joinTask(Task task)
@VisibleForTesting
protected TaskStatus doTask(Task task, boolean run)
{
+ TaskStatus taskStatus = TaskStatus.failure(task.getId(), "Task execution
never started");
Review Comment:
A bit weird to initialize status with a failure one, don't think we need it.
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -417,6 +424,16 @@ public void registerListener(TaskRunnerListener listener,
Executor executor)
final Pair<TaskRunnerListener, Executor> listenerPair = Pair.of(listener,
executor);
log.debug("Registered listener [%s]", listener.getListenerId());
listeners.add(listenerPair);
+
+ for (Map.Entry<String, KubernetesWorkItem> entry : tasks.entrySet()) {
+ if (entry.getValue().isRunning()) {
+ TaskRunnerUtils.notifyLocationChanged(
Review Comment:
fyi I don't see the listener from supervisor is doing much work.
https://github.com/apache/druid/blob/28.0.0/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java#L1663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
