suneet-s commented on code in PR #15133:
URL: https://github.com/apache/druid/pull/15133#discussion_r1361052998
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -203,12 +203,11 @@ protected synchronized TaskStatus join(long timeout)
throws IllegalStateExceptio
finally {
try {
saveLogs();
- shutdown();
}
catch (Exception e) {
- log.warn(e, "Cleanup failed for task [%s]", taskId);
+ log.warn(e, "Log processing failed for task [%s]", taskId);
}
-
+ shutdown();
Review Comment:
Can `shutdown()` throw an exception? since it is making a call to the
kubernetes client. If so, the stopTask should probably be in it's own finally
block
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateLocationAction.java:
##########
@@ -23,11 +23,10 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
-import com.google.common.base.Optional;
import org.apache.druid.indexer.TaskLocation;
import org.apache.druid.indexing.common.task.Task;
-import org.apache.druid.indexing.overlord.TaskRunner;
+@Deprecated
Review Comment:
A comment or javadoc here explaining why it's deprecated / when it is safe
for someone to remove would be helpful in case someone comes across this in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
