suneet-s commented on code in PR #15133:
URL: https://github.com/apache/druid/pull/15133#discussion_r1358642273
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesWorkItem.java:
##########
@@ -36,9 +36,17 @@ public class KubernetesWorkItem extends TaskRunnerWorkItem
private final Task task;
private KubernetesPeonLifecycle kubernetesPeonLifecycle = null;
- public KubernetesWorkItem(Task task, ListenableFuture<TaskStatus>
statusFuture)
+ private final SettableFuture<TaskStatus> result;
+
+ public KubernetesWorkItem(Task task)
+ {
+ this(task, SettableFuture.create());
+ }
+
+ public KubernetesWorkItem(Task task, SettableFuture<TaskStatus> result)
Review Comment:
```suggestion
@VisibleForTesting
KubernetesWorkItem(Task task, SettableFuture<TaskStatus> result)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
