suneet-s commented on PR #15133: URL: https://github.com/apache/druid/pull/15133#issuecomment-1761969291
+1 the approach makes sense to me. Some small code suggestions. > but have the peon be directly responsible for the task lifecycle by using the UpdateStatusAction as a way to mark the task future as complete. With this change, can you test a few scenarios where a peon is killed directly from k8s while it is still processing data: * peon running a query_worker task * peon running a query_controller task * peon for a supervisor task (either kafka or kinesis should be fine) * peon running a compact task * peon running an index_parallel task * peon running a compact / index_parallel subtask (like partial_dimension_distribution or something) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
