suneet-s commented on code in PR #15133:
URL: https://github.com/apache/druid/pull/15133#discussion_r1358545493
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -242,13 +249,13 @@ protected void
emitTaskStateMetrics(KubernetesPeonLifecycle.State state, String
@Override
public void updateStatus(Task task, TaskStatus status)
{
- TaskRunnerUtils.notifyStatusChanged(listeners, task.getId(), status);
- }
+ KubernetesWorkItem workItem = tasks.get(task.getId());
+ if (workItem != null && !workItem.getResult().isDone() &&
status.isComplete()) {
+ workItem.setResult(status);
+ }
- @Override
- public void updateLocation(Task task, TaskLocation location)
- {
- TaskRunnerUtils.notifyLocationChanged(listeners, task.getId(), location);
Review Comment:
Can you also delete the default method in `TaskRunner#updateLocation` it
looks like this was the only implementation that did anything.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java:
##########
@@ -155,11 +151,6 @@ public String setup(TaskToolbox toolbox) throws Exception
FileUtils.mkdirp(attemptDir);
reportsFile = new File(attemptDir, "report.json");
statusFile = new File(attemptDir, "status.json");
- InetAddress hostName = InetAddress.getLocalHost();
- DruidNode node = toolbox.getTaskExecutorNode();
- toolbox.getTaskActionClient().submit(new
UpdateLocationAction(TaskLocation.create(
- hostName.getHostAddress(), node.getPlaintextPort(),
node.getTlsPort(), node.isEnablePlaintextPort()
Review Comment:
Can you mark the `UpdateLocationAction` as `@Deprecated` because it looks
like it is no longer used after these changes. Perhaps leave a comment in the
javadocs for `UpdateLocationAction` explaining that it is left around to help
with rolling upgrades from Druid 25 with mm-less ingestion to Druid 28 with
mm-less ingestion. And that it will be removed in a future release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
