suneet-s commented on code in PR #15133:
URL: https://github.com/apache/druid/pull/15133#discussion_r1358586778
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -190,9 +203,10 @@ protected synchronized TaskStatus join(long timeout)
throws IllegalStateExceptio
finally {
try {
saveLogs();
+ shutdown();
Review Comment:
nit: Move this to a finally block in case something in saveLogs throws a
runtime exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
