CryoThrust commented on issue #12087: URL: https://github.com/apache/seatunnel/issues/12087#issuecomment-5536389821
The phased boundary is clear. A few implementation details may be worth making normative before Phase 1 coding starts: (1) define the freshness timestamp and clock-skew tolerance for worker samples, since `metrics_valid` otherwise becomes ambiguous across nodes; (2) make the recommendation identity include `masterEpoch` plus a monotonic generation, with consumers rejecting stale generations; (3) specify whether the 300/600s stabilization windows are wall-clock windows over samples or consecutive scheduler ticks, and how missing samples reset them; (4) expose the exact contributing signals and blocking conditions in the REST payload so an operator can reproduce a recommendation from metrics; and (5) state that advisory recommendations are idempotent and do not create a cooldown until an external actuator reports convergence. These contracts would make the Phase 1 implementation testable without coupling it to Kubernetes or future drain logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
