DanielLeens commented on issue #12087: URL: https://github.com/apache/seatunnel/issues/12087#issuecomment-5559104780
Thanks @JeremyXin. I checked the linked first implementation PR #12140 against the Phase 1 boundary recorded here. The PR remains advisory-only, which is necessary, but its current scope is not the agreed first slice. It adds engine-common autoscaler configuration and YAML parsing, the default config file, REST status/metrics/history services and servlets, Prometheus exports, and user documentation. Those are public configuration and REST/metrics adapter work; the prior decision explicitly kept the initial contribution server-local and deferred those adapters. Please split the work before it is reviewed as the first Phase 1 implementation. The first PR should stay under seatunnel-engine-server in the server-local autoscale package: immutable models, the pure policy evaluator, monotonic-clock stabilization, safe signal collection, fencing/idempotency, and deterministic contract tests only. It must not add engine-common configuration, YAML/default-config changes, REST endpoints, metric exports, or documentation for those public surfaces. A later integration PR can expose the already-tested model through configuration, REST, and metrics. The current Build is still in progress, so this scope correction is required independently of CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
