CryoThrust commented on issue #12087: URL: https://github.com/apache/seatunnel/issues/12087#issuecomment-5551371613
The updated STIP now closes the Phase-1 contracts I previously called out: freshness and future-skew handling, monotonic stabilization semantics, epoch/generation fencing, explainable metrics, idempotent advisory publication, and restart/failover test coverage. I support moving forward with this boundary. One implementation detail to preserve in the first PR: keep the recommendation value object and pure policy evaluator independent of REST/Prometheus adapters. That allows the conflict cases (scheduler blocking vs utilization, Fixed Slot vs Dynamic Slot, stale samples) to be tested without a running Zeta master. The adapters can then be thin projections of the same evaluated snapshot, avoiding drift between API and metrics. For the first implementation slice, I suggest the acceptance order be: 1. immutable snapshot/recommendation models with validation of epoch, generation, timestamps and UNKNOWN Dynamic Slot utilization; 2. deterministic policy evaluator and stabilization tracker using an injected monotonic clock; 3. contract tests for stale/future samples, handover reset, duplicate recommendation publication and all signal-conflict cases; 4. only then wire the advisory result into REST/metrics. Please point me to the preferred package/module for the Phase-1 API/value objects when ready. I will avoid adding an implementation PR before that location and interface ownership are confirmed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
