[ 
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899071
 ]

ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/24 23:24
            Start Date: 10/Jan/24 23:24
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#issuecomment-1885916617

   ## 
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3855?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`22248e4`)](https://app.codecov.io/gh/apache/gobblin/commit/22248e4f2b01859c7e833b99f6770a2d4bd15d6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 47.56% compared to head 
[(`81757ce`)](https://app.codecov.io/gh/apache/gobblin/pull/3855?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 45.98%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3855      +/-   ##
   ============================================
   - Coverage     47.56%   45.98%   -1.59%     
   + Complexity    11068     2185    -8883     
   ============================================
     Files          2160      417    -1743     
     Lines         85563    18051   -67512     
     Branches       9509     2199    -7310     
   ============================================
   - Hits          40700     8301   -32399     
   + Misses        41154     8865   -32289     
   + Partials       3709      885    -2824     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3855?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 899071)
    Remaining Estimate: 0h
            Time Spent: 10m

> remove `Optional` from fields in gobblin service code that are actually 
> mandataory
> ----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1983
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to