[ 
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899077
 ]

ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jan/24 01:34
            Start Date: 11/Jan/24 01:34
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1448182793


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -284,7 +264,7 @@ public void orchestrate(Spec spec, Properties jobProps, 
long triggerTimestampMil
           return;
         }
         Dag<JobExecutionPlan> compiledDag = compiledDagOptional.get();
-        if (compiledDag == null || compiledDag.isEmpty()) {
+        if (compiledDag.isEmpty()) {
           
FlowCompilationValidationHelper.populateFlowCompilationFailedEventMessage(eventSubmitter,
 spec, flowMetadata);
           Instrumented.markMeter(this.flowOrchestrationFailedMeter);

Review Comment:
   It is used here, the parameter changed from Optional<X> to X





Issue Time Tracking
-------------------

    Worklog Id:     (was: 899077)
    Time Spent: 0.5h  (was: 20m)

> remove `Optional` from fields in gobblin service code that are actually 
> mandataory
> ----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1983
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to