[
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899076
]
ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/24 01:14
Start Date: 11/Jan/24 01:14
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1448167913
##########
gobblin-core-base/src/main/java/org/apache/gobblin/instrumented/Instrumented.java:
##########
@@ -255,6 +259,10 @@ public static void markMeter(Optional<Meter> meter) {
markMeter(meter, 1);
}
+ public static void markMeter(Meter meter) {
Review Comment:
where is this being used?
Issue Time Tracking
-------------------
Worklog Id: (was: 899076)
Time Spent: 20m (was: 10m)
> remove `Optional` from fields in gobblin service code that are actually
> mandataory
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1983
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)