[
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899081
]
ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/24 01:56
Start Date: 11/Jan/24 01:56
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1448188136
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -109,10 +109,10 @@ public class Orchestrator implements SpecCatalogListener,
Instrumentable {
private final ClassAliasResolver<SpecCompiler> aliasResolver;
+ @Inject
public Orchestrator(Config config, Optional<TopologyCatalog>
topologyCatalog, Optional<DagManager> dagManager,
Review Comment:
I'd argue that, like the `EventSubmitter`, the `DagManager` is no longer
justifiably `Optional`. while we're at it, can we clean this up too?
also, what of the `Optional<TopologyCatalog>`?
Issue Time Tracking
-------------------
Worklog Id: (was: 899081)
Time Spent: 1h 10m (was: 1h)
> remove `Optional` from fields in gobblin service code that are actually
> mandataory
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1983
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)