[ 
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899082
 ]

ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jan/24 01:56
            Start Date: 11/Jan/24 01:56
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1448191206


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -66,7 +66,7 @@ public final class FlowCompilationValidationHelper {
    * caller.
    * @param flowSpec
    * @param optionalFlowExecutionId for scheduled (non-ad-hoc) flows, to pass 
the ID "laundered" via the DB;
-   *                                see: {@link MysqlMultiActiveLeaseArbiter 
javadoc section titled
+   *                                see: {@link 
org.apache.gobblin.runtime.api.MysqlMultiActiveLeaseArbiter javadoc section 
titled

Review Comment:
   was this necessary?  (I didn't see you remove an `import`)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 899082)
    Time Spent: 1h 20m  (was: 1h 10m)

> remove `Optional` from fields in gobblin service code that are actually 
> mandataory
> ----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1983
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to