[
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899078
]
ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/24 01:54
Start Date: 11/Jan/24 01:54
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1448191206
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -66,7 +66,7 @@ public final class FlowCompilationValidationHelper {
* caller.
* @param flowSpec
* @param optionalFlowExecutionId for scheduled (non-ad-hoc) flows, to pass
the ID "laundered" via the DB;
- * see: {@link MysqlMultiActiveLeaseArbiter
javadoc section titled
+ * see: {@link
org.apache.gobblin.runtime.api.MysqlMultiActiveLeaseArbiter javadoc section
titled
Review Comment:
why was this necessary? (I didn't see you remove an import)
##########
gobblin-core-base/src/main/java/org/apache/gobblin/instrumented/Instrumented.java:
##########
@@ -41,6 +39,8 @@
import com.google.common.collect.Lists;
import com.google.common.io.Closer;
+import javax.annotation.Nonnull;
Review Comment:
when I see:
> Import order: java, org, com, gobblin.
here - https://gobblin.apache.org/docs/developer-guide/CodingStyle/
I had always presume `javax` would go next to `java`, not between `com` and
`gobblin`. are you sure this is supposed to move here?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -109,10 +109,10 @@ public class Orchestrator implements SpecCatalogListener,
Instrumentable {
private final ClassAliasResolver<SpecCompiler> aliasResolver;
+ @Inject
public Orchestrator(Config config, Optional<TopologyCatalog>
topologyCatalog, Optional<DagManager> dagManager,
Review Comment:
I'd argue that, similarly to the `EventSubmitter` the `DagManager` is no
longer justifiably `Optional`. while we're at it, can we clean this up too?
also, what of the `Optional<TopologyCatalog>`?
##########
gobblin-core-base/src/main/java/org/apache/gobblin/instrumented/Instrumented.java:
##########
@@ -255,6 +259,10 @@ public static void markMeter(Optional<Meter> meter) {
markMeter(meter, 1);
}
+ public static void markMeter(Meter meter) {
Review Comment:
my related Q is whether we still require the `Optional` version or could
*replace* them w/ this one
Issue Time Tracking
-------------------
Worklog Id: (was: 899078)
Time Spent: 40m (was: 0.5h)
> remove `Optional` from fields in gobblin service code that are actually
> mandataory
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1983
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)