[ 
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899079
 ]

ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jan/24 01:55
            Start Date: 11/Jan/24 01:55
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1448183753


##########
gobblin-core-base/src/main/java/org/apache/gobblin/instrumented/Instrumented.java:
##########
@@ -41,6 +39,8 @@
 import com.google.common.collect.Lists;
 import com.google.common.io.Closer;
 
+import javax.annotation.Nonnull;

Review Comment:
   when I see:
   > Import order: java, org, com, gobblin.
   
   here - https://gobblin.apache.org/docs/developer-guide/CodingStyle/
   
   I had always presume `javax` would go next to `java`, not between `com` and 
`gobblin`.  are you sure this is supposed to move here?
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 899079)
    Time Spent: 50m  (was: 40m)

> remove `Optional` from fields in gobblin service code that are actually 
> mandataory
> ----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1983
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to