[ 
https://issues.apache.org/jira/browse/GOBBLIN-1983?focusedWorklogId=899290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899290
 ]

ASF GitHub Bot logged work on GOBBLIN-1983:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jan/24 21:41
            Start Date: 11/Jan/24 21:41
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1449429719


##########
gobblin-core-base/src/main/java/org/apache/gobblin/instrumented/Instrumented.java:
##########
@@ -255,6 +259,10 @@ public static void markMeter(Optional<Meter> meter) {
     markMeter(meter, 1);
   }
 
+  public static void markMeter(Meter meter) {

Review Comment:
   There are many non-gaas callers to this method with Optional parameter, 
which may be providing parameter that is truly optional.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 899290)
    Time Spent: 1h 50m  (was: 1h 40m)

> remove `Optional` from fields in gobblin service code that are actually 
> mandataory
> ----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1983
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1983
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to