sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616445398
##########
File path:
plc4j/drivers/canopen/src/main/java/org/apache/plc4x/java/canopen/CANOpenPlcDriver.java
##########
@@ -111,8 +112,8 @@ protected BaseOptimizer getOptimizer() {
}
@Override
- protected ProtocolStackConfigurer<CANOpenFrame> getStackConfigurer() {
- return SingleProtocolStackConfigurer.builder(CANOpenFrame.class,
CANOpenSocketCANFrameIO.class)
+ protected ProtocolStackConfigurer<CANOpenFrame>
getStackConfigurer(Configuration configuration, Transport transport) {
+ return SingleProtocolStackConfigurer.builder(CANOpenFrame.class,
CANOpenSocketCANFrameIO.class, configuration)
.withProtocol(CANOpenProtocolLogic.class)
Review comment:
this would then be the code in the SingleProtocolStackConfigurer:
```
if (protocolClass != null)
protocol = configure(configuration,
createInstance(protocolClass));
else
protocol = protocolSupplier(configuration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
