splatch commented on a change in pull request #241: URL: https://github.com/apache/plc4x/pull/241#discussion_r616461714
########## File path: plc4j/spi/src/main/java/org/apache/plc4x/java/spi/EventListenerMessageCodec.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.plc4x.java.spi; + +import io.netty.channel.ChannelHandlerContext; +import io.netty.handler.codec.MessageToMessageCodec; +import org.apache.plc4x.java.api.listener.EventListener; +import org.apache.plc4x.java.api.listener.MessageExchangeListener; +import org.apache.plc4x.java.spi.generation.Message; + +import java.util.List; + +/** + * Codec which propagate received or sent messages to connection event listeners. + */ +public class EventListenerMessageCodec extends MessageToMessageCodec<Message, Message> { + + private final List<EventListener> listeners; + + public EventListenerMessageCodec(List<EventListener> listeners) { + this.listeners = listeners; + } + + @Override + protected void encode(ChannelHandlerContext ctx, Message msg, List<Object> out) throws Exception { + if (msg instanceof Message) { Review comment: It really depends on order in which codecs are added - this was an extra fence I made while looking right place to add codec. So yeah, this `if` statement can be safely removed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
