sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616449259
##########
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##########
@@ -42,69 +47,57 @@
public class SingleProtocolStackConfigurer<BASE_PACKET_CLASS extends Message>
implements ProtocolStackConfigurer<BASE_PACKET_CLASS> {
Review comment:
The whole idea of the `SingleProtocolStackConfigurer ` is to work class
based.
So maybe we rename this configurer into `SingleDIProtocolStackConfigurer`
and we create a second `SingleSupplierProtocolStackConfigurer`.
Like now you force every stack to use the new api instead of providing an
alternate for for drivers where its neccessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
