splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616467389
##########
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##########
@@ -42,69 +47,57 @@
public class SingleProtocolStackConfigurer<BASE_PACKET_CLASS extends Message>
implements ProtocolStackConfigurer<BASE_PACKET_CLASS> {
Review comment:
I have removed configuration handling from configurer cause now it is
available to builder. Given above we now can have multiple builders which
construct stack in different ways. One note, leaving
`SingleProtocolStackConfigurer` with its initial class based approach will
require us to introduce second type which will differ only by single lines.
These lines will be calls to suppliers instead of reflection.
Are you suggesting to revert `SingleSupplierProtocolStackConfigurer` and
duplicate its functionality to other place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
