splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616468290
##########
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##########
@@ -142,31 +141,86 @@ public
SingleProtocolStackBuilder(Class<BASE_PACKET_CLASS> basePacketClass, Clas
}
public SingleProtocolStackBuilder<BASE_PACKET_CLASS>
withProtocol(Class<? extends Plc4xProtocolBase<BASE_PACKET_CLASS>> protocol) {
- this.protocol = protocol;
+ return withProtocol(configuredType(protocol));
Review comment:
I think we can safely follow @sruehl suggestion to have two versions of
stack configurers (or at least builders) - one which supports injections and
other which does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
