chrisdutz commented on a change in pull request #241: URL: https://github.com/apache/plc4x/pull/241#discussion_r616474494
########## File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/EventPlcConnection.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.plc4x.java.api; + +import org.apache.plc4x.java.api.listener.EventListener; + +/** + * An extended kind of connection which can broadcast events. + * + * Particular type of event might vary, it might be a connection state or message exchange. + */ +public interface EventPlcConnection extends PlcConnection { Review comment: Well if you change the core of things it is natural that they need changes in a lot of places ;-) ... the later you introduce the change, the more you need to change. But I would not be in favor of a change that makes our users have to do instanceof stuff in order to use the API. You wouldn't have to do all on your own. We could probably all do our part. I do think that some sort of "ups I think I just lost the connection" mechanism is indeed very important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
