sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616472268
##########
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##########
@@ -42,69 +47,57 @@
public class SingleProtocolStackConfigurer<BASE_PACKET_CLASS extends Message>
implements ProtocolStackConfigurer<BASE_PACKET_CLASS> {
Review comment:
Basically yes: This also would clean up the PR diff as we could then
clearly see at which point we need the second configurer. The missing
documentation on the configurer is on me (we where pretty time limited back
then) :)
I will document it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
