sruehl commented on a change in pull request #241: URL: https://github.com/apache/plc4x/pull/241#discussion_r616478823
########## File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/EventPlcConnection.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.plc4x.java.api; + +import org.apache.plc4x.java.api.listener.EventListener; + +/** + * An extended kind of connection which can broadcast events. + * + * Particular type of event might vary, it might be a connection state or message exchange. + */ +public interface EventPlcConnection extends PlcConnection { Review comment: I mean @splatch has a valid point regarding the pool, so maybe we can merge these to together later when we have full support. Otherwise this feature would be blocked till we have support in pool for example. From an interface perspective this should be fine as we don't expose the api yet when it's not guaranteed to work the intended way. Once this is validated we can just pull the methods up into the PlcConnection. Implementation wise merging later should have almost now effect when done later then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
