On 2/8/2017 11:09 PM, Nick Sabalausky wrote:
And any PRs I have managed to get through were all uphill battles the whole way.
You have contributed 5 PRs to dmd:
1 is open (it's controversial)
1 closed (today by me)
1 in 6 days
2 in 1 day
Overall, I think you've done well.
5 PRs, 3 merged.
14 PRs, 1 merged. (I didn't check all the reviews, but the ones I did
In any case, shouldn't it be an uphill battle to merge things? There are a lot
of things that need to be satisfied to merge something. Being too hasty leads to
legacy code that we come to regret, angry people whose code was broken, and
Check out our current list of regressions:
Hasty merges wind up there, and usually someone other than the one who broke it
has to fix it.