<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
William Allen Simpson wrote: > <URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 > > > Jason Dorje Short wrote: >> William Allen Simpson wrote: >>> (2) One of them has not worked for about two years, and certainly was not >>> tested at the time it was committed. >> I'm quite sure it worked when it was committed. >> > Here's the patch from your message of Wed, 16 Nov 2005 18:35:19 -0800, > and I don't see any difference from what was there last week: > > @@ -2324,10 +2623,9 @@ > **************************************************************************/ > void key_quickselect(enum quickselect_type qtype) > { > - struct unit *punit; > + unit_list_iterate(get_units_in_focus(), punit) { > + struct unit *punit2 = quickselect(punit->tile, qtype); > > - if(punit_focus) { > - punit = quickselect(punit_focus->tile, qtype); > - set_unit_focus_and_select(punit); > - } > + set_unit_focus_and_select(punit2); > + } unit_list_iterate_end; > } Yes, the previously working behavior was broken in that commit, and nobody noticed until it was released since all the good multiplayer players use the stable branch. We know this already. > Have you tested <control>LMB and RMB? I don't have a useful test scenario. They work but I'm not sure if it's as the behavior is intended. Obviously this code should be examined. -jason _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
