> J> (apparently gives problems with extended keys).
> 
>      Which ones?

As you possibly know, by reading port 60h you send the keyboard controller an 
"interrupt acknowledged" signal, so it can send the next byte. On real 
hardware this takes some time (some microseconds at least), but qemu is unable 
to emulate this slight delay. So everytime the keyboard controller has to send 
more than 1 byte (as it is the case with the extended keys for example), qemu 
will get confused if port 60h is read unnecessarily and send the next byte too 
fast.

> I think, not "not hurt" - this "must have" modification. Because
> original code lost all previous flags and enables interrupts on exit (which
> may be undesirable by caller).

Yes, aggreed, but most likely you will not find a real-life application where 
this is indeed a problem.

> PS: There are more changes, which I not mention, and which are not
> commented. For example,

You promised not to mention them, so why do you nevertheless?

> what does DebugBreak? (Letters "swat" suggest, that
> this relates to 386SWAT debugger?)

yes I wanted to call 386swat on exceptions - if it was loaded

> Then, you change "map" from "1.75M" to
> "1.5M" - by which reasons? I suggest, this may have bad effect, because
> Michael found (though, as always, not comment) some issues, which relate to
> size of preallocated memory.

IMO this is a safe optimization, at least since recently because the address 
context is switched now to the host for the VCPI memory functions - this is 
part of the main issue.

> Also, you add some deals with "client stack" -
> no comments what wrong with original code.

But this is the main issue. Please read my explanation in Bugzilla.

> You replace some code by "clts" -
> is it code optimization (reduction) or something more?

Just an optimization.




-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user

Reply via email to