----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4014 -----------------------------------------------------------
Nice! This is actually way simpler than I expected. Seems like at some point we'd want to (1) set the simulation quantum from the main script based on the etherlink delay and (2) maybe have a check in the etherlink object that asserts that if the SimObjects on the two ends belong to different event queues, then the simulation quantum is at least as large as the latency. I guess #2 is optional since you'd get an assertion once the simulation started running and handleAsyncInsertions() tried to schedule an event in the past (that's what should happen, anyway), but it would be friendlier to generate a cleaner error message up front. configs/common/FSConfig.py <http://reviews.gem5.org/r/1700/#comment3872> It looks like this wouldn't work for the realview system, is that right? tests/configs/twosys-tsunami-simple-atomic.py <http://reviews.gem5.org/r/1700/#comment3873> I think this is redundant, right? drive_sys should inherit eventq_index from root. For that matter, root should default to 0 as well, so only the 'test_sys.eventq_index = 1' line is strictly necessary. I'm not opposed to leaving the other lines in for documentation purposes. - Steve Reinhardt On Feb. 10, 2013, 1:48 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1700/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:050c11c6e40b > --------------------------- > etherlink: add simobjects at the endpoints to the link structure > > > Diffs > ----- > > configs/common/FSConfig.py ff4b1bde5f60 > src/dev/Ethernet.py ff4b1bde5f60 > src/dev/etherlink.hh ff4b1bde5f60 > src/dev/etherlink.cc ff4b1bde5f60 > src/dev/etherobject.hh ff4b1bde5f60 > tests/configs/twosys-tsunami-simple-atomic.py ff4b1bde5f60 > > Diff: http://reviews.gem5.org/r/1700/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
