----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4021 -----------------------------------------------------------
configs/common/FSConfig.py <http://reviews.gem5.org/r/1700/#comment3893> Is there a way we can derive int0/int1 from end0/end1, or vice versa? It seems redundant (and potentially error-prone) to have to set them separately. src/dev/etherlink.cc <http://reviews.gem5.org/r/1700/#comment3892> Does it make sense that we're only serializing one end of the link here? - Steve Reinhardt On Feb. 10, 2013, 1:48 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1700/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:050c11c6e40b > --------------------------- > etherlink: add simobjects at the endpoints to the link structure > > > Diffs > ----- > > configs/common/FSConfig.py ff4b1bde5f60 > src/dev/Ethernet.py ff4b1bde5f60 > src/dev/etherlink.hh ff4b1bde5f60 > src/dev/etherlink.cc ff4b1bde5f60 > src/dev/etherobject.hh ff4b1bde5f60 > tests/configs/twosys-tsunami-simple-atomic.py ff4b1bde5f60 > > Diff: http://reviews.gem5.org/r/1700/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
