----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4020 -----------------------------------------------------------
configs/common/FSConfig.py <http://reviews.gem5.org/r/1700/#comment3890> It's a separate issue, but somehow it would be good to solve the naming or have some kind of alias for the common bits that does not involve tsunami, realview, pc etc. That would make the scripts much neater. src/dev/Ethernet.py <http://reviews.gem5.org/r/1700/#comment3889> Is it really SimObject we need? Is it not EventManagers? Perhaps I'm missing the point. src/dev/etherlink.cc <http://reviews.gem5.org/r/1700/#comment3891> I would be good to add a check that the values are sensible (no NULL), unless that's covered by the Python machinery. - Andreas Hansson On Feb. 10, 2013, 1:48 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1700/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:050c11c6e40b > --------------------------- > etherlink: add simobjects at the endpoints to the link structure > > > Diffs > ----- > > configs/common/FSConfig.py ff4b1bde5f60 > src/dev/Ethernet.py ff4b1bde5f60 > src/dev/etherlink.hh ff4b1bde5f60 > src/dev/etherlink.cc ff4b1bde5f60 > src/dev/etherobject.hh ff4b1bde5f60 > tests/configs/twosys-tsunami-simple-atomic.py ff4b1bde5f60 > > Diff: http://reviews.gem5.org/r/1700/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
