> On Feb. 12, 2013, 1:41 p.m., Steve Reinhardt wrote: > > src/dev/etherlink.cc, line 254 > > <http://reviews.gem5.org/r/1700/diff/1/?file=33955#file33955line254> > > > > Does it make sense that we're only serializing one end of the link here?
I think that change is not correct. I rolling back some of the proposed changes so as to take care of this. > On Feb. 12, 2013, 1:41 p.m., Steve Reinhardt wrote: > > configs/common/FSConfig.py, line 563 > > <http://reviews.gem5.org/r/1700/diff/1/?file=33952#file33952line563> > > > > Is there a way we can derive int0/int1 from end0/end1, or vice versa? > > It seems redundant (and potentially error-prone) to have to set them > > separately. While it should be possible to do so, it does not seem straight forward enough to me. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4021 ----------------------------------------------------------- On Feb. 16, 2013, 9:44 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1700/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2013, 9:44 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9543:b01e713cf4ef > --------------------------- > etherlink: add simobjects at the endpoints to the link structure > > > Diffs > ----- > > configs/common/FSConfig.py 0ac00d9a8aaf > src/dev/Ethernet.py 0ac00d9a8aaf > src/dev/etherlink.hh 0ac00d9a8aaf > src/dev/etherlink.cc 0ac00d9a8aaf > src/dev/etherobject.hh 0ac00d9a8aaf > tests/configs/twosys-tsunami-simple-atomic.py 0ac00d9a8aaf > > Diff: http://reviews.gem5.org/r/1700/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
