> On Feb. 12, 2013, 11:08 a.m., Andreas Hansson wrote: > > src/dev/etherlink.cc, line 59 > > <http://reviews.gem5.org/r/1700/diff/1/?file=33955#file33955line59> > > > > I would be good to add a check that the values are sensible (no NULL), > > unless that's covered by the Python machinery.
Since I am not assigning any default value to these params, IIRC, some python script does complain that the params do not have any assigned / default value. > On Feb. 12, 2013, 11:08 a.m., Andreas Hansson wrote: > > src/dev/Ethernet.py, line 50 > > <http://reviews.gem5.org/r/1700/diff/1/?file=33953#file33953line50> > > > > Is it really SimObject we need? Is it not EventManagers? > > > > Perhaps I'm missing the point. You right that an event manager should be enough. But, event managers cannot be passed as params. And I don't see the need to type cast these sim objects to event managers. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4020 ----------------------------------------------------------- On Feb. 10, 2013, 1:48 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1700/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:050c11c6e40b > --------------------------- > etherlink: add simobjects at the endpoints to the link structure > > > Diffs > ----- > > configs/common/FSConfig.py ff4b1bde5f60 > src/dev/Ethernet.py ff4b1bde5f60 > src/dev/etherlink.hh ff4b1bde5f60 > src/dev/etherlink.cc ff4b1bde5f60 > src/dev/etherobject.hh ff4b1bde5f60 > tests/configs/twosys-tsunami-simple-atomic.py ff4b1bde5f60 > > Diff: http://reviews.gem5.org/r/1700/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
