paleolimbot commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1410763728
##########
r/configure:
##########
@@ -293,15 +293,15 @@ set_pkg_vars () {
# If we have pkg-config, it will tell us what libarrow needs
set_lib_dir_with_pc () {
- LIB_DIR="`${PKG_CONFIG} --variable=libdir --silence-errors
${PKG_CONFIG_NAME}`"
+ LIB_DIR="`${PKG_CONFIG} --variable=libdir ${PKG_CONFIG_NAME}`"
Review Comment:
I would prefer to keep this type of output. A long history of aggressively
silencing useful debug output has led to quite a lot of development time for us
(and there's no indication that this type of ouput would occur and lead to
success anywhere except a CRAN MacOS build).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
