paleolimbot commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1410890571
##########
r/tools/nixlibs.R:
##########
@@ -295,32 +295,32 @@ determine_binary_from_stderr <- function(errs) {
if (is.null(attr(errs, "status"))) {
# There was no error in compiling: so we found libcurl and OpenSSL >= 1.1,
# openssl is < 3.0
- lg("Found libcurl and OpenSSL >= 1.1")
+ lg("Found headers for libcurl and OpenSSL >= 1.1")
Review Comment:
It's for us when seeing build logs for environments that we can't replicate
or haven't replicated yet or don't have control over. I think it is reasonable
to err on the side of verbosity/correctness out of respect for those degugging
the build (be it CRAN team members, us, or Arrow maintainers not familiar with
the R build).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
