paleolimbot commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1410886422
##########
r/configure:
##########
@@ -293,15 +293,15 @@ set_pkg_vars () {
# If we have pkg-config, it will tell us what libarrow needs
set_lib_dir_with_pc () {
- LIB_DIR="`${PKG_CONFIG} --variable=libdir --silence-errors
${PKG_CONFIG_NAME}`"
+ LIB_DIR="`${PKG_CONFIG} --variable=libdir ${PKG_CONFIG_NAME}`"
Review Comment:
Either way we need the changes here to ensure that this (and perhaps the
next few) CRAN submissions can go smoothly.
I think the issue is that we're generally not sure if we do or do not need
this type of output until we get build logs from a user (or a CRAN). This type
of output is the most valuable for environments that we can't replicate or
haven't replicated yet. At the point that the build fails, I think that this
type of output is even more critical than a passing build with verbose output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
