jonkeane commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1411143355
##########
r/configure:
##########
@@ -293,15 +293,15 @@ set_pkg_vars () {
# If we have pkg-config, it will tell us what libarrow needs
set_lib_dir_with_pc () {
- LIB_DIR="`${PKG_CONFIG} --variable=libdir --silence-errors
${PKG_CONFIG_NAME}`"
+ LIB_DIR="`${PKG_CONFIG} --variable=libdir ${PKG_CONFIG_NAME}`"
Review Comment:
But we didn't use these messages on CRAN to diagnose anything (and frankly I
don't think had we generally seen them we would have known what was going on to
fix if they had been there in the first place without the other more verbose
changes we made when things go sidewise), so I'm skeptical about the amount
they will help versus be noise that is confusing.
If we're going to have them be there, at the very least could we collect
them up and then dump them only if there's a failure in this process (+describe
that they are useful only to maintainers)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
