jonkeane commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1410803914
##########
r/configure:
##########
@@ -293,15 +293,15 @@ set_pkg_vars () {
# If we have pkg-config, it will tell us what libarrow needs
set_lib_dir_with_pc () {
- LIB_DIR="`${PKG_CONFIG} --variable=libdir --silence-errors
${PKG_CONFIG_NAME}`"
+ LIB_DIR="`${PKG_CONFIG} --variable=libdir ${PKG_CONFIG_NAME}`"
Review Comment:
> and there's no indication that this type of ouput would occur and lead to
success anywhere except a CRAN MacOS build
I'm honestly more concerned with the case where this output happens and the
build fails elsewhere and that confuses people as to what the real issue is
than this popping up + it succeeding.
I hear the concern about development time, and for that IMO we should strive
to replicate CRAN environments when we need to (and like we've done) + put this
behind debug flags so we can see it when we need it (or even as default in our
CI) but not expose this to users. These messages will only confuse people who
see them outside of us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
