paleolimbot commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1411176772
##########
r/configure:
##########
@@ -293,15 +293,15 @@ set_pkg_vars () {
# If we have pkg-config, it will tell us what libarrow needs
set_lib_dir_with_pc () {
- LIB_DIR="`${PKG_CONFIG} --variable=libdir --silence-errors
${PKG_CONFIG_NAME}`"
+ LIB_DIR="`${PKG_CONFIG} --variable=libdir ${PKG_CONFIG_NAME}`"
Review Comment:
Perhaps that would be a good follow-up PR for 15.0.0? For unblocking the
current release I think this is necessary (in case the failures are not what we
think they are) and that it is the right way to do it (i.e., without adding too
much bash to our already very complicated process).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
