assignUser commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1411065148
##########
r/configure:
##########
@@ -293,15 +293,15 @@ set_pkg_vars () {
# If we have pkg-config, it will tell us what libarrow needs
set_lib_dir_with_pc () {
- LIB_DIR="`${PKG_CONFIG} --variable=libdir --silence-errors
${PKG_CONFIG_NAME}`"
+ LIB_DIR="`${PKG_CONFIG} --variable=libdir ${PKG_CONFIG_NAME}`"
Review Comment:
> I'm honestly more concerned with the case where this output happens and
the build fails elsewhere and that confuses people as to what the real issue is
than this popping up + it succeeding.
From my experience people will not even see that, they just see the cmake
error (which is likely the last output if the build proceeds even for some
reason e.g. #38769) and open an issue. In addition I don't really want to have
to do a 'turn on debug options on cran so we can pinpoint the
issue'-submissions anymore out of respect for the cran resources as well as my
time waiting for the check to be finally run (which took several days this time
around) and of course the time of nic/the maintainer to do the
submission(especially now that the 'need' for secrecy is gone).
And while theoretically reproducing the CRAN environment would work, there
is just not enough info to do that as we have seen with this issue. (I would of
course love to be able to do that but even having an actual 10.13 runner didn't
protect us...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
