assignUser commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1411082227
##########
r/tools/nixlibs.R:
##########
@@ -295,32 +295,32 @@ determine_binary_from_stderr <- function(errs) {
if (is.null(attr(errs, "status"))) {
# There was no error in compiling: so we found libcurl and OpenSSL >= 1.1,
# openssl is < 3.0
- lg("Found libcurl and OpenSSL >= 1.1")
+ lg("Found headers for libcurl and OpenSSL >= 1.1")
Review Comment:
I am ambivalent on this as the issue of seeing 'found libcurl' followed by
'failed to find libcurl' was cleared up by generalizing the second message but
this version is also more accurate so :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
