assignUser commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1411395288
##########
r/configure:
##########
@@ -293,15 +293,15 @@ set_pkg_vars () {
# If we have pkg-config, it will tell us what libarrow needs
set_lib_dir_with_pc () {
- LIB_DIR="`${PKG_CONFIG} --variable=libdir --silence-errors
${PKG_CONFIG_NAME}`"
+ LIB_DIR="`${PKG_CONFIG} --variable=libdir ${PKG_CONFIG_NAME}`"
Review Comment:
> But we didn't use these messages on CRAN to diagnose anything
We didn't use them because they were suppressed until I removed the flags in
this PR. In hindsight we should have removed them for the debug build but
hindsight is 20/20.
> and frankly I don't think had we generally seen them we would have known
what was going on to fix
I would have been able to diagnose the issue if we had them turned on for
the first submission and we would have even more information, as we would know
if it is actually the macos system libcurl issue that led me to repro an error
that presented the same or an issue with a different library/cause. And it
would have saved us a bunch of time trying to trouble shoot, failing,
submitting again, ...
> could we collect them up and then dump them only if there's a failure
Not easily/without changing a bunch of the logic into a much more brittle
form or adding obtuse `sh` :magic_wand: .
In any case we need to keep them turned on for 14.0.0.2 as @paleolimbot has
said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
